From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@suse.com>
Subject: Re: [PATCH V5 10/15] Add arch specific module handling
 to read_file()
Date: Tue, 23 Sep 2014 13:28:20 +0100
Message-ID: <5421838402000078000379A0@mail.emea.novell.com>
References: <1411080607-32365-1-git-send-email-roy.franz@linaro.org>
	<1411080607-32365-11-git-send-email-roy.franz@linaro.org>
	<542035B20200007800036ED3@mail.emea.novell.com>
	<CAFECyb9DhtaUyhaMAm9Jsz+5SWW=DUCfwcBr5WsyRSwY6u1e-A@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <CAFECyb9DhtaUyhaMAm9Jsz+5SWW=DUCfwcBr5WsyRSwY6u1e-A@mail.gmail.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Roy Franz <roy.franz@linaro.org>
Cc: keir <keir@xen.org>, Ian Campbell <ian.campbell@citrix.com>, tim <tim@xen.org>, xen-devel <xen-devel@lists.xen.org>, Stefano Stabellini <stefano.stabellini@citrix.com>, Fu Wei <fu.wei@linaro.org>
List-Id: xen-devel@lists.xenproject.org

>>> On 23.09.14 at 03:57, <roy.franz@linaro.org> wrote:
> On Mon, Sep 22, 2014 at 5:44 AM, Jan Beulich <JBeulich@suse.com> wrote:
>>>>> On 19.09.14 at 00:50, <roy.franz@linaro.org> wrote:
>>> @@ -115,6 +116,15 @@ static void __init DisplayUint(UINT64 Val, INTN Width)
>>>      PrintStr(PrintString);
>>>  }
>>>
>>> +static size_t __init wstrlen(const CHAR16 * s)
>>> +{
>>> +     const CHAR16 *sc;
>>> +
>>> +     for (sc = s; *sc != L'\0'; ++sc)
>>> +             /* nothing */;
>>> +     return sc - s;
>>> +}
>>
>> Coding style (many issues).
> 
> static size_t __init wstrlen(const CHAR16 *s)
> {
>      const CHAR16 *sc;
> 
>      for ( sc = s; *sc != L'\0'; ++sc )
>             ;
>      return sc - s;
> }
> 
> Is the above OK?  Not sure what else to change here...

Almost - the lone ; is still indented one level (4 spaces) too deep.

Jan