From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH for-4.5 v8 06/19] xen: Relocate mem_event_op domctl and access_op memop into common. Date: Tue, 23 Sep 2014 14:32:22 +0100 Message-ID: <542192860200007800037BB5@mail.emea.novell.com> References: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de> <1411478070-13836-7-git-send-email-tklengyel@sec.in.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1411478070-13836-7-git-send-email-tklengyel@sec.in.tum.de> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Tamas K Lengyel Cc: ian.campbell@citrix.com, tim@xen.org, julien.grall@linaro.org, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, stefano.stabellini@citrix.com, andres@lagarcavilla.org, dgdegra@tycho.nsa.gov List-Id: xen-devel@lists.xenproject.org >>> On 23.09.14 at 15:14, wrote: > Signed-off-by: Tamas K Lengyel > Acked-by: Jan Beulich > Acked-by: Tim Deegan > --- > v8: Move the new enable_msr_exit_interception test into the p2m layer. Again invalidating earlier acks imo. > --- a/xen/common/mem_event.c > +++ b/xen/common/mem_event.c > @@ -623,12 +623,9 @@ int mem_event_domctl(struct domain *d, > xen_domctl_mem_event_op_t *mec, > HVM_PARAM_ACCESS_RING_PFN, > mem_access_notification); > > - if ( mec->op != XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE && > - rc == 0 && hvm_funcs.enable_msr_exit_interception ) > - { > - d->arch.hvm_domain.introspection_enabled = 1; > - hvm_funcs.enable_msr_exit_interception(d); > - } > + if ( !rc && mec->op != XEN_DOMCTL_MEM_EVENT_OP_ACCESS_ENABLE ) > + p2m_enable_msr_exit_interception(d); The name is clearly not suitable for an abstraction - there's certainly not going to be MSRs on each and every CPU architecture. Maybe consult with Razvan on an agreeable more suitable name. Jan