From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH for-4.5 v8 05/19] xen: Relocate
 set_access_required domctl into common
Date: Wed, 24 Sep 2014 15:18:46 +0100
Message-ID: <5422D2C6.7000709@linaro.org>
References: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de>
	<1411478070-13836-6-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411478070-13836-6-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

Hi Tamas,

On 09/23/2014 02:14 PM, Tamas K Lengyel wrote:
> @@ -1116,6 +1117,20 @@ long do_domctl(XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>      }
>      break;
>  
> +    case XEN_DOMCTL_set_access_required:
> +    {
> +        struct p2m_domain* p2m;
> +
> +        ret = -EPERM;
> +        if ( current->domain == d )
> +            break;
> +
> +        ret = 0;
> +        p2m = p2m_get_hostp2m(d);
> +        p2m->access_required = op->u.access_required.access_required;
> +    }
> +    break;
> +

IHMO this DOMCTL should only exist when mem access is supported/compiled
for the specific architecture. (i.e when HAS_MEM_ACCESS is defined).

Regards,

-- 
Julien Grall