From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWnpN-0006hS-Kk for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:46:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XWnpG-0003Pb-6K for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:45:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XWnpF-0003Ny-UG for qemu-devel@nongnu.org; Wed, 24 Sep 2014 10:45:50 -0400 Message-ID: <5422D910.9070503@redhat.com> Date: Wed, 24 Sep 2014 08:45:36 -0600 From: Eric Blake MIME-Version: 1.0 References: <20140825111951.31112.50251.stgit@fimbulvetr.bsc.es> <20140825111957.31112.31733.stgit@fimbulvetr.bsc.es> In-Reply-To: <20140825111957.31112.31733.stgit@fimbulvetr.bsc.es> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7Jc8e1m5kKqi2pWXLmOBiHAR6HHQQCrCL" Subject: Re: [Qemu-devel] [PATCH v4 1/2] trace: [qmp] Add commands to query and control event tracing state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TGx1w61zIFZpbGFub3Zh?= , qemu-devel@nongnu.org Cc: Michael Roth , Markus Armbruster , Stefan Hajnoczi , Luiz Capitulino This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7Jc8e1m5kKqi2pWXLmOBiHAR6HHQQCrCL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 08/25/2014 05:19 AM, Llu=C3=ADs Vilanova wrote: > Signed-off-by: Llu=C3=ADs Vilanova > --- > qapi-schema.json | 3 ++ > qapi/trace.json | 65 +++++++++++++++++++++++++++++++++++++++++++= + > qmp-commands.hx | 35 ++++++++++++++++++++++++ > trace/Makefile.objs | 1 + > trace/qmp.c | 75 +++++++++++++++++++++++++++++++++++++++++++= ++++++++ > 5 files changed, 179 insertions(+) > create mode 100644 qapi/trace.json > create mode 100644 trace/qmp.c > +## > +# @trace-event-set-state: > +# > +# Set the dynamic tracing state of events. > +# > +# @name: Event name pattern (case-sensitive glob). > +# @enable: Whether to enable tracing. > +# @ignore-unavailable: #optional Do not match unavailable events with = @name. Would be nice to state that this bool defaults to false (at least, that's my assumption). > + > +Query the state of events. > + > +Example: > + > +-> { "execute": "trace-event-get-state", "arguments": { "name": "qemu_= memalign" } } > +<- { "return": [ { "name": "qemu_memalign", "state": "disabled" } ] } It would be nice to use a glob in the "name" of the example, and show a multi-element array as the result. Those changes can be done in a followup patch, since Stefan has already queued this patch. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7Jc8e1m5kKqi2pWXLmOBiHAR6HHQQCrCL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg iQEcBAEBCAAGBQJUItkQAAoJEKeha0olJ0NqtSYH/iMB1gYcgCrRXKEX4rVmy2MB WUY/9sp+T0DBcUG81sA6x6fA+py+GvsnfXNoskI562YyQ7hNvElAu7ty/zmxWYxV qEPfiyT3Vex32ybRv5dZ8fKshoBhzU3/JeUjrYE2or4CZ7wKXZzaSb9zFRnwFCyP z7OZBqsuMfSy4gzw0XCiTZc7p9x974wDmESEgyhnNqKjGLAePdH7TjlFAFiP9Yb+ tV1micxKhnVFQT4se9u8/Gn1YN8CHXcfgUgrm04q+V+rgkImS6bWA3yvqphsnb5p 3mH45ssvbterZEWnYkQM5Gp/lVk2XTbART0c5IPsttBtqYAbMKMfsP0de944umo= =s+WJ -----END PGP SIGNATURE----- --7Jc8e1m5kKqi2pWXLmOBiHAR6HHQQCrCL--