From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45689)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XWodh-0007EJ-HV
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:38:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1XWodZ-0001UZ-Kq
	for qemu-devel@nongnu.org; Wed, 24 Sep 2014 11:37:57 -0400
Message-ID: <5422E53A.7020606@redhat.com>
Date: Wed, 24 Sep 2014 17:37:30 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1411572143-40345-1-git-send-email-agraf@suse.de>
	<1411572143-40345-3-git-send-email-agraf@suse.de>
In-Reply-To: <1411572143-40345-3-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 2/7] sysbus: Make devices spawnable via
	-device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>, qemu-ppc@nongnu.org
Cc: peter.maydell@linaro.org, peter.crosthwaite@xilinx.com, eric.auger@linaro.org, qemu-devel@nongnu.org, sean.stalley@intel.com, afaerber@suse.de

Il 24/09/2014 17:22, Alexander Graf ha scritto:
> +static int error_on_sysbus_device(SysBusDevice *sbdev, void *opaque)
> +{
> +    error_report("Device '%s' can not be handled by this machine",
> +                 qdev_fw_name(DEVICE(sbdev)));
> +    exit(1);
> +}

The firmware name is usually somewhat opaque.  Maybe use the class name,
and use

'-device %s' cannot be handled by this machine

?  (Note "cannot" is a single word.  "can not be handled" means that the
machine may or may not handle it).

Paolo