From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [PATCH for-4.5 v8 16/19] xen/arm: Instruction
 prefetch abort (X) mem_event handling
Date: Wed, 24 Sep 2014 16:41:00 +0100
Message-ID: <5422E60C.2010007@linaro.org>
References: <1411478070-13836-1-git-send-email-tklengyel@sec.in.tum.de>
	<1411478070-13836-17-git-send-email-tklengyel@sec.in.tum.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1411478070-13836-17-git-send-email-tklengyel@sec.in.tum.de>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tamas K Lengyel <tklengyel@sec.in.tum.de>, xen-devel@lists.xen.org
Cc: ian.campbell@citrix.com, tim@xen.org, ian.jackson@eu.citrix.com, stefano.stabellini@citrix.com, andres@lagarcavilla.org, jbeulich@suse.com, dgdegra@tycho.nsa.gov
List-Id: xen-devel@lists.xenproject.org

Hello Tamas,

On 09/23/2014 02:14 PM, Tamas K Lengyel wrote:
> +        unsigned long s1ptw:1; /* Fault during a stage 1 translation table walk */

[..]

> +        unsigned long s1ptw:1; /* Fault during a stage 1 translation table walk */

The description is confusing, it gives the impression that this bit is
used to know if the fault has occurred a stage 1 translation table walk
or not. I would say: "Stage 2 fault during a stage 1 translation table
walk".

Regards,

-- 
Julien Grall