From: Shuah Khan <shuahkh@osg.samsung.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
LKML <linux-kernel@vger.kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Shuah Khan <shuah.kh@samsung.com>,
Tom Zanussi <tom.zanussi@linux.intel.com>,
Oleg Nesterov <oleg@redhat.com>,
Fengguang Wu <fengguang.wu@intel.com>,
Ingo Molnar <mingo@kernel.org>,
Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases
Date: Wed, 24 Sep 2014 10:22:12 -0600 [thread overview]
Message-ID: <5422EFB4.2050104@osg.samsung.com> (raw)
In-Reply-To: <20140924120853.0a717b7e@gandalf.local.home>
On 09/24/2014 10:08 AM, Steven Rostedt wrote:
> On Wed, 24 Sep 2014 10:01:38 -0600
> Shuah Khan <shuahkh@osg.samsung.com> wrote:
>
>> I am working on adding the framework for c tests. We will have
>> to get this evolved for shell scripts. Please see the following
>> thread:
>>
>> https://lkml.org/lkml/2014/9/23/926
>>
>
> Thanks,
>
> Also, what's the rules for a test that requires other tools. Some of my
> tests require trace-cmd to be installed as well as perf. My stress test
> runs perf against trace-cmd running hackbench (another required tool),
> but I believe that perf has hackbench built in so I could replace
> hackbench with the perf version.
>
One simple approach is to have the user install the required tools
for the test. Indicate what is needed and fail the test with
appropriate message with xskip. This is what I have in mind for
tests that can't be run because of a missing config. The same can
be extended to external tools that the test depends on.
thanks,
-- Shuah
--
Shuah Khan
Sr. Linux Kernel Developer
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978
next prev parent reply other threads:[~2014-09-24 16:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 21:38 [RFC][PATCH] ftracetest: Add a couple of ftrace test cases Steven Rostedt
2014-09-24 2:58 ` Masami Hiramatsu
2014-09-24 15:42 ` Steven Rostedt
2014-09-24 15:58 ` Steven Rostedt
2014-09-24 16:01 ` Shuah Khan
2014-09-24 16:08 ` Steven Rostedt
2014-09-24 16:22 ` Shuah Khan [this message]
2014-09-24 16:30 ` Steven Rostedt
2014-09-24 16:36 ` Shuah Khan
2014-09-26 12:04 ` Masami Hiramatsu
2014-09-26 14:18 ` Steven Rostedt
2014-09-29 10:33 ` Masami Hiramatsu
2014-09-26 6:06 ` Namhyung Kim
2014-09-26 11:54 ` Masami Hiramatsu
2014-09-26 14:46 ` Namhyung Kim
2014-09-29 11:40 ` Masami Hiramatsu
2014-09-30 6:24 ` Namhyung Kim
2014-09-26 14:07 ` Steven Rostedt
2014-09-25 0:35 ` Masami Hiramatsu
2014-09-25 1:14 ` Steven Rostedt
2014-09-25 3:20 ` Masami Hiramatsu
2014-09-25 1:29 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5422EFB4.2050104@osg.samsung.com \
--to=shuahkh@osg.samsung.com \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=shuah.kh@samsung.com \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.