From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751875AbaIXQhA (ORCPT ); Wed, 24 Sep 2014 12:37:00 -0400 Received: from lists.s-osg.org ([54.187.51.154]:37500 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbaIXQg7 (ORCPT ); Wed, 24 Sep 2014 12:36:59 -0400 Message-ID: <5422F328.2040707@osg.samsung.com> Date: Wed, 24 Sep 2014 10:36:56 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Steven Rostedt CC: Masami Hiramatsu , LKML , Namhyung Kim , Shuah Khan , Tom Zanussi , Oleg Nesterov , Fengguang Wu , Ingo Molnar , Shuah Khan Subject: Re: [RFC][PATCH] ftracetest: Add a couple of ftrace test cases References: <20140923173846.603cb49c@gandalf.local.home> <5422336A.6030304@hitachi.com> <20140924114235.4287f4a1@gandalf.local.home> <20140924115811.6eeeab8c@gandalf.local.home> <5422EAE2.6080005@osg.samsung.com> <20140924120853.0a717b7e@gandalf.local.home> <5422EFB4.2050104@osg.samsung.com> <20140924123007.7fcb0099@gandalf.local.home> In-Reply-To: <20140924123007.7fcb0099@gandalf.local.home> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/24/2014 10:30 AM, Steven Rostedt wrote: > On Wed, 24 Sep 2014 10:22:12 -0600 > Shuah Khan wrote: > > >> One simple approach is to have the user install the required tools >> for the test. Indicate what is needed and fail the test with >> appropriate message with xskip. This is what I have in mind for >> tests that can't be run because of a missing config. The same can >> be extended to external tools that the test depends on. > > Should I hold off adding my tests until we have all this in place. Or > should I just push my tests with simply passing if the config isn't > supported for now and add it later? > > I wont add any of the tests that require other tools besides echo, grep > and cat. > Please go ahead and get them in. The framework might have to wait until 3.19, so there is no need to have it gate test development. We can evolve them as we go. If tests require special, it means that they aren't suitable for certain envs such as qemu boot with busybox. There is a plan to add test targets to cover such cases. I would recommend at least printing a message saying what you are missing if you find something missing. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978