From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXUYk-0005EB-1F for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:23:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XXUYd-0003SY-N5 for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:23:37 -0400 Received: from mailapp01.imgtec.com ([195.59.15.196]:44722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XXUYd-0003Qo-Gp for qemu-devel@nongnu.org; Fri, 26 Sep 2014 08:23:31 -0400 Message-ID: <54255ABC.5000804@imgtec.com> Date: Fri, 26 Sep 2014 13:23:24 +0100 From: James Hogan MIME-Version: 1.0 References: <1403882530-47821-1-git-send-email-leon.alrae@imgtec.com> <1403882530-47821-4-git-send-email-leon.alrae@imgtec.com> In-Reply-To: <1403882530-47821-4-git-send-email-leon.alrae@imgtec.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 03/21] target-mips: add SELEQZ and SELNEZ instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae , qemu-devel@nongnu.org Cc: yongbok.kim@imgtec.com, cristian.cuna@imgtec.com, aurelien@aurel32.net, rth@twiddle.net Hi Leon, On 27/06/14 16:21, Leon Alrae wrote: > diff --git a/target-mips/translate.c b/target-mips/translate.c > index 931a580..bb95f7b 100644 > --- a/target-mips/translate.c > +++ b/target-mips/translate.c > @@ -189,6 +189,9 @@ enum { > OPC_MOVZ = 0x0A | OPC_SPECIAL, > OPC_MOVN = 0x0B | OPC_SPECIAL, > > + OPC_SELEQZ = 0x35 | OPC_SPECIAL, > + OPC_SELNEZ = 0x37 | OPC_SPECIAL, > + > OPC_MOVCI = 0x01 | OPC_SPECIAL, > > /* Special */ maybe it makes sense to remove OPC_SPECIAL35_RESERVED and OPC_SPECIAL37_RESERVED now too. Cheers James