All of lore.kernel.org
 help / color / mirror / Atom feed
From: Waiman Long <waiman.long@hp.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org,
	Scott J Norton <scott.norton@hp.com>,
	Douglas Hatch <doug.hatch@hp.com>,
	Don Zickus <dzickus@redhat.com>, Jiri Olsa <jolsa@kernel.org>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH v4 1/2] perf tool: encapsulate dsos list head into struct dsos
Date: Mon, 29 Sep 2014 13:26:55 -0400	[thread overview]
Message-ID: <5429965F.2070806@hp.com> (raw)
In-Reply-To: <20140926141230.GB3879@kernel.org>

On 09/26/2014 10:12 AM, Arnaldo Carvalho de Melo wrote:
> Em Wed, Sep 24, 2014 at 11:45:39AM -0400, Waiman Long escreveu:
>> This is a precursor patch to enable long name searching of DSOs
>> using the rbtree. In this patch, a new dsos structure is created
>> which contains only a list head structure for the moment. The new
>> dsos structure is used, in turn, in the machine structure for the
>> user_dsos and kernel_dsos fields. Only the following 3 dsos functions
>> are modified to accept the new dsos structure parameter instead
>> of list_head:
>>   - dsos__add()
>>   - dsos__find()
>>   - __dsos__findnew()
>>
>> Because of the need to find out the corresponding dsos structure to
>> properly call dsos__add() in dso__load_sym() of util/symbol-elf.c,
>> a new dsos field is also added to the dso structure.
> What tree did you use to produce these patches? I just tried on my
> perf/core branch and I get some fuzzes:
>
> [acme@zoo linux]$ patch -p1<  /wb/1.patch
> patching file tools/perf/util/dso.c
> Hunk #1 succeeded at 755 (offset 2 lines).
> Hunk #2 succeeded at 852 (offset 2 lines).
> patching file tools/perf/util/dso.h
> patching file tools/perf/util/header.c
> patching file tools/perf/util/machine.c
> Hunk #2 succeeded at 72 (offset 2 lines).
> Hunk #3 succeeded at 477 (offset 29 lines).
> Hunk #4 succeeded at 994 (offset 29 lines).
> patching file tools/perf/util/machine.h
> Hunk #2 succeeded at 39 with fuzz 1 (offset 1 line).
> patching file tools/perf/util/probe-event.c
> patching file tools/perf/util/symbol-elf.c
> Hunk #1 succeeded at 929 (offset 13 lines).
> [acme@zoo linux]$
>
> I'll fix this up, probably harmless, just a heads up.
>
> - Arnaldo

I was using the latest linux 3.17 tree. I should have used the tip tree 
instead. I will use that if I need to sent out a new patch.

-Longman

  reply	other threads:[~2014-09-29 17:26 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-24 15:45 [PATCH v4 0/2] perf tool: improves DSO long names search speed with rbtree Waiman Long
2014-09-24 15:45 ` [PATCH v4 1/2] perf tool: encapsulate dsos list head into struct dsos Waiman Long
2014-09-26 14:06   ` Arnaldo Carvalho de Melo
2014-09-29  3:54     ` Namhyung Kim
2014-09-29 17:30       ` Waiman Long
2014-09-29 18:09         ` Arnaldo Carvalho de Melo
2014-09-29 18:40           ` Waiman Long
2014-09-26 14:12   ` Arnaldo Carvalho de Melo
2014-09-29 17:26     ` Waiman Long [this message]
2014-09-29 18:07       ` Arnaldo Carvalho de Melo
2014-09-24 15:45 ` [PATCH v4 2/2] perf tool: improves DSO long names lookup speed with rbtree Waiman Long
2014-09-26 14:22   ` Arnaldo Carvalho de Melo
2014-09-29  4:02     ` Namhyung Kim
2014-09-29 17:25       ` Waiman Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5429965F.2070806@hp.com \
    --to=waiman.long@hp.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=doug.hatch@hp.com \
    --cc=dzickus@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paulus@samba.org \
    --cc=peterz@infradead.org \
    --cc=scott.norton@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.