From mboxrd@z Thu Jan 1 00:00:00 1970 From: "M, Satheeshakrishna" Subject: Re: [PATCH 65/89] drm/i915/skl: Always use DPLL0 for eDP Date: Wed, 01 Oct 2014 16:22:13 +0530 Message-ID: <542BDCDD.3080402@intel.com> References: <1409830075-11139-1-git-send-email-damien.lespiau@intel.com> <1409830075-11139-66-git-send-email-damien.lespiau@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 1DABE6E359 for ; Wed, 1 Oct 2014 03:52:24 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Paulo Zanoni , Damien Lespiau Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 9/23/2014 8:37 PM, Paulo Zanoni wrote: > 2014-09-04 8:27 GMT-03:00 Damien Lespiau: >> From: Satheeshakrishna M >> >> DPLL0 is not part of the shared PLL infrastructure. We'll use on for >> eDP and rely on what the BIOS does for now. >> >> Signed-off-by: Satheeshakrishna M >> Signed-off-by: Damien Lespiau >> --- >> drivers/gpu/drm/i915/intel_dp.c | 5 ++++- >> 1 file changed, 4 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c >> index 5755f59..93bd9bf 100644 >> --- a/drivers/gpu/drm/i915/intel_dp.c >> +++ b/drivers/gpu/drm/i915/intel_dp.c >> @@ -1005,7 +1005,10 @@ found: >> &pipe_config->dp_m2_n2); >> } >> >> - if (IS_HASWELL(dev) || IS_BROADWELL(dev)) >> + if (IS_SKYLAKE(dev)) { >> + if (is_edp(intel_dp)) >> + pipe_config->ddi_pll_sel = SKL_DPLL0; > So we just don't assign anything else for the other ports? Why exactly? Other ports follow the shared dpll logic and assignment happens in intel_ddi > >> + } else if (IS_HASWELL(dev) || IS_BROADWELL(dev)) >> hsw_dp_set_ddi_pll_sel(pipe_config, intel_dp->link_bw); >> else >> intel_dp_set_clock(encoder, pipe_config, intel_dp->link_bw); >> -- >> 1.8.3.1 >> >> _______________________________________________ >> Intel-gfx mailing list >> Intel-gfx@lists.freedesktop.org >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx >