From mboxrd@z Thu Jan 1 00:00:00 1970 From: David L Stevens Subject: Re: [PATCH net-next 2/2] sunvnet: vnet_start_xmit() must hold a refcnt on port. Date: Wed, 01 Oct 2014 15:31:49 -0400 Message-ID: <542C56A5.4070805@oracle.com> References: <20141001185622.GI17706@oracle.com> <542C50A4.30304@oracle.com> <20141001192325.GK17706@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, raghuram.kothakota@oracle.com, netdev@vger.kernel.org To: Sowmini Varadhan Return-path: Received: from aserp1040.oracle.com ([141.146.126.69]:29037 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbaJATby (ORCPT ); Wed, 1 Oct 2014 15:31:54 -0400 In-Reply-To: <20141001192325.GK17706@oracle.com> Sender: netdev-owner@vger.kernel.org List-ID: On 10/01/2014 03:23 PM, Sowmini Varadhan wrote: > On (10/01/14 15:06), David L Stevens wrote: >> >> This "vp->switch_port" addition doesn't appear to be related to the port refcnt >> change, and doesn't allow for multiple switch ports. > > The switch_port is the connection to Dom0. Do you envision us having more than > one switch_port? How? While Dom0 might only create one port with the "switch" flag, the flag just means "I can reach anybody" and is not inherently unique. I don't think an attached VM should assume there is always only one; it prevents multipath load balancing kinds of things in the future. Also, there is the broader point that this sort of change should be a separate patch. It isn't required for fixing the dangling reference -- it is an independent change. +-DLS