From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Grinberg Date: Fri, 03 Oct 2014 09:45:15 +0300 Subject: [U-Boot] [PATCH 2/2] arm: mx6: cm_fx6: use gpio request In-Reply-To: <1412259444-11959-3-git-send-email-nikita@compulab.co.il> References: <1412215048-565-7-git-send-email-sjg@chromium.org> <1412259444-11959-1-git-send-email-nikita@compulab.co.il> <1412259444-11959-3-git-send-email-nikita@compulab.co.il> Message-ID: <542E45FB.1030001@compulab.co.il> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Nikita, On 10/02/14 17:17, Nikita Kiryanov wrote: > Use gpio_request for all the gpios that are utilized by various > subsystems in cm-fx6, and refactor the relevant init functions > so that all gpios are requested during board_init(), not during > subsystem init, thus avoiding the need to manage gpio ownership > each time a subsystem is initialized. > > The new division of labor is: > During board_init() muxes are setup and gpios are requested. > During subsystem init gpios are toggled. > > Cc: Igor Grinberg > Cc: Simon Glass > Signed-off-by: Nikita Kiryanov This looks much better. I really don't like sticking the "has_been_inited" style of plugs, while the same can be done by design and w/o such plugs. Thanks Nikita. Acked-by Igor Grinberg -- Regards, Igor.