From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaFxR-0007FM-6r for qemu-devel@nongnu.org; Fri, 03 Oct 2014 23:24:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XaFxL-0006eA-Ee for qemu-devel@nongnu.org; Fri, 03 Oct 2014 23:24:33 -0400 Received: from mail-ob0-f176.google.com ([209.85.214.176]:41361) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XaFxL-0006e0-BI for qemu-devel@nongnu.org; Fri, 03 Oct 2014 23:24:27 -0400 Received: by mail-ob0-f176.google.com with SMTP id m8so1798757obr.7 for ; Fri, 03 Oct 2014 20:24:25 -0700 (PDT) Message-ID: <542F6867.8090304@mvista.com> Date: Fri, 03 Oct 2014 22:24:23 -0500 From: Corey Minyard MIME-Version: 1.0 References: <1412266658-25643-1-git-send-email-minyard@acm.org> <1412266658-25643-6-git-send-email-minyard@acm.org> <542F21A9.2050001@redhat.com> In-Reply-To: <542F21A9.2050001@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/6] qemu-char: Add reconnecting to client sockets List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , minyard@acm.org, qemu-devel@nongnu.org Cc: bcketchum@gmail.com, mjg59@srcf.ucam.org, hwd@huawei.com, afaerber@suse.de, mst@redhat.com On 10/03/2014 05:22 PM, Paolo Bonzini wrote: > Il 02/10/2014 18:17, minyard@acm.org ha scritto: >> + if (!qemu_chr_open_socket_fd(chr, &err)) { >> + error_report("Unable to connect to char device %s\n", chr->label); >> + qemu_chr_socket_restart_timer(chr); >> + } > Can you please add a follow-up patch that only prints this message once > per reconnect? Otherwise a server that shuts down can spam logs forever. Yes, not a problem. I always wonder the best way to handle something like that, but you are probably right. > I'll nevertheless queue the patches for 2.2 next week. Thank you, -corey > Thanks, > > Paolo