From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH libdrm 07/11] xf86drmMode.h: Add DisplayPort MST encoder type
Date: Sun, 25 Jan 2015 01:40 +0200 [thread overview]
Message-ID: <5430484.CntsL5BKAh@avalon> (raw)
In-Reply-To: <1422029304-1926-8-git-send-email-thierry.reding@gmail.com>
Hi Thierry,
Thank you for the patch.
On Friday 23 January 2015 17:08:20 Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> This brings xf86drmMode.h in sync with include/drm/drm_mode.h.
> Eventually we really should only have a single set of definitions rather
> than duplicating this in two files.
The purpose of these duplicate definitions is to avoid application build
breakages when compiled against an old drm.h header that doesn't include
drm_modes.h. Given that drm_modes.h has been introduced in 2.6.39 more than 6
years ago, wouldn't it be time to drop this ?
If we need to support old distributions (such as RHEL 5 for instance) shipping
kernel headers older than 2.6.39, do we still need to keep the definitions in
sync with newer kernel headers ? Build breakages would only occur when
compiling an application that makes use of the new definitions against old
kernel headers. If the distribution is stuck on <2.6.39 I doubt it will ship
applications using recent DRM features.
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> xf86drmMode.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xf86drmMode.h b/xf86drmMode.h
> index e70c16d437f4..70f14a1ae506 100644
> --- a/xf86drmMode.h
> +++ b/xf86drmMode.h
> @@ -130,6 +130,7 @@ extern "C" {
> #define DRM_MODE_ENCODER_TVDAC 4
> #define DRM_MODE_ENCODER_VIRTUAL 5
> #define DRM_MODE_ENCODER_DSI 6
> +#define DRM_MODE_ENCODER_DPMST 7
>
> #define DRM_MODE_SUBCONNECTOR_Automatic 0
> #define DRM_MODE_SUBCONNECTOR_Unknown 0
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-01-24 23:39 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-23 16:08 [PATCH libdrm 00/11] Random assortment of fixes and enhancements Thierry Reding
2015-01-23 16:08 ` [PATCH libdrm 01/11] libdrm: valgrind-clear a few more IOCTL arguments Thierry Reding
2015-01-24 23:19 ` Laurent Pinchart
2015-01-23 16:08 ` [PATCH libdrm 02/11] libdrm: Remove gratuitous blank lines Thierry Reding
2015-01-24 23:19 ` Laurent Pinchart
2015-01-23 16:08 ` [PATCH libdrm 03/11] libdrm: Make indentation consistent Thierry Reding
2015-01-24 23:20 ` Laurent Pinchart
2015-01-23 16:08 ` [PATCH libdrm 04/11] tests: Split helpers into library Thierry Reding
2015-01-24 23:24 ` Laurent Pinchart
2015-01-29 15:27 ` [PATCH 04.1/11] SQUASH: tests: misc cleanups Emil Velikov
2015-01-29 15:27 ` [PATCH 04.2/11] SQUASH: util: add android build Emil Velikov
2015-01-23 16:08 ` [PATCH libdrm 05/11] tests: Move name tables to libutil Thierry Reding
2015-01-24 23:24 ` Laurent Pinchart
2015-01-29 15:28 ` [PATCH 05.1/11] SQUASH: util: add the kms.[ch] to makefile.sources Emil Velikov
2015-01-23 16:08 ` [PATCH libdrm 06/11] xf86drmMode.h: Use consistent padding Thierry Reding
2015-01-24 23:26 ` Laurent Pinchart
2015-01-23 16:08 ` [PATCH libdrm 07/11] xf86drmMode.h: Add DisplayPort MST encoder type Thierry Reding
2015-01-24 23:40 ` Laurent Pinchart [this message]
2015-01-23 16:08 ` [PATCH libdrm 08/11] tests: modetest: Accept connector names Thierry Reding
2015-01-24 23:56 ` Laurent Pinchart
2015-01-26 10:14 ` Thierry Reding
2015-01-26 10:24 ` Laurent Pinchart
2015-01-23 16:08 ` [PATCH libdrm 09/11] tests: Add libkms-test library Thierry Reding
2015-01-29 15:30 ` [PATCH 09.1/11] SQUASH: libkms-test: add missing header to the distribution Emil Velikov
2015-01-23 16:08 ` [PATCH libdrm 10/11] tests: kms: Implement CRTC stealing test Thierry Reding
2015-01-29 15:30 ` [PATCH 10.1/11] SQUASH: kms-steal-crtc: link against cairo Emil Velikov
2015-01-23 16:08 ` [PATCH libdrm 11/11] tests: kms: Implement universal planes test Thierry Reding
2015-01-29 15:31 ` [PATCH 11.1/11] SQUASH: kms-universal-planes: link against cairo Emil Velikov
2015-01-29 15:36 ` [PATCH libdrm 00/11] Random assortment of fixes and enhancements Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5430484.CntsL5BKAh@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.