All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francis Moreau <francis.moro@gmail.com>
To: "Dale R. Worley" <worley@alum.mit.edu>
Cc: util-linux@vger.kernel.org, Karel Zak <kzak@redhat.com>
Subject: Re: losetup on a image file containing (GPT) partition doesn't create partition devices
Date: Mon, 06 Oct 2014 17:56:32 +0200	[thread overview]
Message-ID: <5432BBB0.30701@gmail.com> (raw)
In-Reply-To: <201410061547.s96Fl0sN021617@hobgoblin.ariadne.com>

[Adding Karel in CC]

On 10/06/2014 05:47 PM, Dale R. Worley wrote:
>> From: Francis Moreau <francis.moro@gmail.com>
> 
>> Ok, so IMHO I think that losetup(8) should issue its own
>> ioctl(BLKRRPART) and shouldn't rely on the kernel during the loop setup
>> since it can fail silently. This way it can check the return value of
>> ioctl() and moght choose to do it again in case the return value is -EBUSY.
>>

Hm I was probably not clear, let me phase it again:

Ok, so IMHO I think that losetup(8) should issue its own
ioctl(BLKRRPART) and shouldn't rely on the kernel during the loop setup
since the kernel can fail silently. Using ioctl(BLKRRPART) allows
losetup(8) to check the return value of ioctl() and might choose to do
it again in case the return value is -EBUSY.

>> Or indicates in the man page that the -P can fail silently.
> 
> It's not clear to me why the kernel would be expected to check itself
> for partitions in this manner.  If losetup does not get the -P option,
> it seems like the kernel should not check.
> 

Thanks

  reply	other threads:[~2014-10-06 15:54 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-03  9:44 losetup on a image file containing (GPT) partition doesn't create partition devices Francis Moreau
2014-10-03 14:29 ` Dale R. Worley
2014-10-03 19:58   ` Dale R. Worley
2014-10-03 20:26     ` Francis Moreau
2014-10-04 19:35       ` Francis Moreau
2014-10-06 15:47         ` Dale R. Worley
2014-10-06 15:56           ` Francis Moreau [this message]
2014-10-27 20:16             ` Mike Frysinger
2014-12-02 19:29               ` Phillip Susi
2014-12-03  8:36                 ` Karel Zak
2014-12-03 14:49                   ` Phillip Susi
2014-12-03 16:10                     ` Karel Zak
2015-02-16  8:52                 ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5432BBB0.30701@gmail.com \
    --to=francis.moro@gmail.com \
    --cc=kzak@redhat.com \
    --cc=util-linux@vger.kernel.org \
    --cc=worley@alum.mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.