From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932132AbaJHLRd (ORCPT ); Wed, 8 Oct 2014 07:17:33 -0400 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:49154 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932077AbaJHLRb (ORCPT ); Wed, 8 Oct 2014 07:17:31 -0400 X-IronPort-AV: E=Sophos;i="5.04,677,1406617200"; d="scan'208";a="47694657" Message-ID: <54351D49.7040104@broadcom.com> Date: Wed, 8 Oct 2014 04:17:29 -0700 From: Scott Branden User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.2 MIME-Version: 1.0 To: Russell King - ARM Linux CC: Christian Daudt , Matt Porter , , Mike Turquette , Alex Elder , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Andrew Morton , "David S. Miller" , Greg Kroah-Hartman , Joe Perches , "Mauro Carvalho Chehab" , Antti Palosaari , JD Zheng , Ray Jui , , , , Jonathan Richardson Subject: Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC References: <1412746025-11998-1-git-send-email-sbranden@broadcom.com> <1412746025-11998-2-git-send-email-sbranden@broadcom.com> <20141008081112.GB5182@n2100.arm.linux.org.uk> In-Reply-To: <20141008081112.GB5182@n2100.arm.linux.org.uk> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14-10-08 01:11 AM, Russell King - ARM Linux wrote: > On Tue, Oct 07, 2014 at 10:27:00PM -0700, Scott Branden wrote: >> +static void __init bcm_cygnus_init(void) >> +{ >> + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); >> + >> + l2x0_of_init(0, ~0UL); > > Please don't explicitly call l2x0 initialisation. Instead, set the > appropriate l2c members here: > >> +DT_MACHINE_START(BCM_CYGNUS_DT, "Broadcom Cygnus SoC") >> + .init_machine = bcm_cygnus_init, >> + .map_io = debug_ll_io_init, >> + .dt_compat = bcm_cygnus_dt_compat, >> + .restart = bcm_cygnus_restart >> +MACHINE_END > > and let the core code call it at the appropriate time. Thanks. > Thanks - was unaware of this functionality. Will add .l2c_aux_val and .l2c_aux mask to DT_MATCHINE_START. BUT, what happens when we need to add trustzone support and make SMC call to secure monitor? From mboxrd@z Thu Jan 1 00:00:00 1970 From: Scott Branden Subject: Re: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC Date: Wed, 8 Oct 2014 04:17:29 -0700 Message-ID: <54351D49.7040104@broadcom.com> References: <1412746025-11998-1-git-send-email-sbranden@broadcom.com> <1412746025-11998-2-git-send-email-sbranden@broadcom.com> <20141008081112.GB5182@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141008081112.GB5182-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Russell King - ARM Linux Cc: Christian Daudt , Matt Porter , bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org, Mike Turquette , Alex Elder , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Andrew Morton , "David S. Miller" , Greg Kroah-Hartman , Joe Perches , Mauro Carvalho Chehab , Antti Palosaari , JD Zheng , Ray Jui , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Jonathan Richardson List-Id: devicetree@vger.kernel.org On 14-10-08 01:11 AM, Russell King - ARM Linux wrote: > On Tue, Oct 07, 2014 at 10:27:00PM -0700, Scott Branden wrote: >> +static void __init bcm_cygnus_init(void) >> +{ >> + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); >> + >> + l2x0_of_init(0, ~0UL); > > Please don't explicitly call l2x0 initialisation. Instead, set the > appropriate l2c members here: > >> +DT_MACHINE_START(BCM_CYGNUS_DT, "Broadcom Cygnus SoC") >> + .init_machine = bcm_cygnus_init, >> + .map_io = debug_ll_io_init, >> + .dt_compat = bcm_cygnus_dt_compat, >> + .restart = bcm_cygnus_restart >> +MACHINE_END > > and let the core code call it at the appropriate time. Thanks. > Thanks - was unaware of this functionality. Will add .l2c_aux_val and .l2c_aux mask to DT_MATCHINE_START. BUT, what happens when we need to add trustzone support and make SMC call to secure monitor? -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: sbranden@broadcom.com (Scott Branden) Date: Wed, 8 Oct 2014 04:17:29 -0700 Subject: [PATCH 1/6] ARM: cygnus: Initial support for Broadcom Cygnus SoC In-Reply-To: <20141008081112.GB5182@n2100.arm.linux.org.uk> References: <1412746025-11998-1-git-send-email-sbranden@broadcom.com> <1412746025-11998-2-git-send-email-sbranden@broadcom.com> <20141008081112.GB5182@n2100.arm.linux.org.uk> Message-ID: <54351D49.7040104@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 14-10-08 01:11 AM, Russell King - ARM Linux wrote: > On Tue, Oct 07, 2014 at 10:27:00PM -0700, Scott Branden wrote: >> +static void __init bcm_cygnus_init(void) >> +{ >> + of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL); >> + >> + l2x0_of_init(0, ~0UL); > > Please don't explicitly call l2x0 initialisation. Instead, set the > appropriate l2c members here: > >> +DT_MACHINE_START(BCM_CYGNUS_DT, "Broadcom Cygnus SoC") >> + .init_machine = bcm_cygnus_init, >> + .map_io = debug_ll_io_init, >> + .dt_compat = bcm_cygnus_dt_compat, >> + .restart = bcm_cygnus_restart >> +MACHINE_END > > and let the core code call it at the appropriate time. Thanks. > Thanks - was unaware of this functionality. Will add .l2c_aux_val and .l2c_aux mask to DT_MATCHINE_START. BUT, what happens when we need to add trustzone support and make SMC call to secure monitor?