From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 10 Oct 2014 16:40:35 +0200 (CEST) Received: from mailapp01.imgtec.com ([195.59.15.196]:43053 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010941AbaJJOkeJcm8M (ORCPT ); Fri, 10 Oct 2014 16:40:34 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 96C144EBA947D for ; Fri, 10 Oct 2014 15:40:24 +0100 (IST) Received: from LEMAIL01.le.imgtec.org (192.168.152.62) by KLMAIL01.kl.imgtec.org (192.168.5.35) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 10 Oct 2014 15:40:27 +0100 Received: from [192.168.154.56] (192.168.154.56) by LEMAIL01.le.imgtec.org (192.168.152.62) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 10 Oct 2014 15:40:26 +0100 Message-ID: <5437EFDA.4060709@imgtec.com> Date: Fri, 10 Oct 2014 15:40:26 +0100 From: Markos Chandras User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Subject: Re: [RFC PATCH V2] MIPS: fix build with binutils 2.24.51+ References: <1408465632-34262-1-git-send-email-manuel.lauss@gmail.com> <20140825125107.GA25892@linux-mips.org> <5437EFB7.2020106@imgtec.com> In-Reply-To: <5437EFB7.2020106@imgtec.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.56] Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 43208 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: Markos.Chandras@imgtec.com Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On 10/10/2014 03:39 PM, Markos Chandras wrote: > On 08/25/2014 08:29 PM, Manuel Lauss wrote: >> On Mon, Aug 25, 2014 at 4:27 PM, Maciej W. Rozycki wrote: >> >>> 1. Determine whether `-Wa,-msoft-float' and `.set hardfloat' are available >>> (a single check will do, they were added to GAS both at the same time) >>> and only enable them if supported by binutils being used to build the >>> kernel, e.g. (for the `.set' part): >>> >>> #ifdef GAS_HAS_SET_HARDFLOAT >>> #define SET_HARDFLOAT .set hardfloat >>> #else >>> #define SET_HARDFLOAT >>> #endif >>> >>> Otherwise we'd have to bump the binutils requirement up to 2.19; this >> >> Do people really update their toolchain so rarely? >> >> >>> 2. Use `.set hardfloat' only around the places that really require it, >>> i.e.: >>> >>> .set push >>> SET_HARDFLOAT >>> # Do the FP stuff. >>> .set pop >>> >>> (so the arch/mips/kernel/r4k_fpu.S piece is good except for maybe using >>> a macro, depending on the outcome of #1 above, but the other ones are >>> not). >> >> I'll update the patch. >> >> Thank you! >> Manuel >> > Hi Manual, > > Just wanted to ping you about this patch. Do you intend to submit a new > version including all the feedback from Ralf, Maciej and Matthew? > s/Manual/Manuel/ :) sorry about that -- markos From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailapp01.imgtec.com ([195.59.15.196]:43053 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S27010941AbaJJOkeJcm8M (ORCPT ); Fri, 10 Oct 2014 16:40:34 +0200 Received: from KLMAIL01.kl.imgtec.org (unknown [192.168.5.35]) by Websense Email Security Gateway with ESMTPS id 96C144EBA947D for ; Fri, 10 Oct 2014 15:40:24 +0100 (IST) Message-ID: <5437EFDA.4060709@imgtec.com> Date: Fri, 10 Oct 2014 15:40:26 +0100 From: Markos Chandras MIME-Version: 1.0 Subject: Re: [RFC PATCH V2] MIPS: fix build with binutils 2.24.51+ References: <1408465632-34262-1-git-send-email-manuel.lauss@gmail.com> <20140825125107.GA25892@linux-mips.org> <5437EFB7.2020106@imgtec.com> In-Reply-To: <5437EFB7.2020106@imgtec.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-subscribe: List-owner: List-post: List-archive: To: linux-mips@linux-mips.org Message-ID: <20141010144026.RCzbsF9FP1oUE7rHfOaSNsO6o5fiVY_BCh6okhDz_vY@z> On 10/10/2014 03:39 PM, Markos Chandras wrote: > On 08/25/2014 08:29 PM, Manuel Lauss wrote: >> On Mon, Aug 25, 2014 at 4:27 PM, Maciej W. Rozycki wrote: >> >>> 1. Determine whether `-Wa,-msoft-float' and `.set hardfloat' are available >>> (a single check will do, they were added to GAS both at the same time) >>> and only enable them if supported by binutils being used to build the >>> kernel, e.g. (for the `.set' part): >>> >>> #ifdef GAS_HAS_SET_HARDFLOAT >>> #define SET_HARDFLOAT .set hardfloat >>> #else >>> #define SET_HARDFLOAT >>> #endif >>> >>> Otherwise we'd have to bump the binutils requirement up to 2.19; this >> >> Do people really update their toolchain so rarely? >> >> >>> 2. Use `.set hardfloat' only around the places that really require it, >>> i.e.: >>> >>> .set push >>> SET_HARDFLOAT >>> # Do the FP stuff. >>> .set pop >>> >>> (so the arch/mips/kernel/r4k_fpu.S piece is good except for maybe using >>> a macro, depending on the outcome of #1 above, but the other ones are >>> not). >> >> I'll update the patch. >> >> Thank you! >> Manuel >> > Hi Manual, > > Just wanted to ping you about this patch. Do you intend to submit a new > version including all the feedback from Ralf, Maciej and Matthew? > s/Manual/Manuel/ :) sorry about that -- markos