From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932711AbcIELWi (ORCPT ); Mon, 5 Sep 2016 07:22:38 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:50651 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbcIELWh (ORCPT ); Mon, 5 Sep 2016 07:22:37 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: QLogic-Storage-Upstream@qlogic.com, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] [SCSI] bnx2fc: mark symbols static where possible Date: Mon, 05 Sep 2016 13:17:23 +0200 Message-ID: <5444175.V8HzkfLa1x@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472971941-4882-1-git-send-email-baoyou.xie@linaro.org> References: <1472971941-4882-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:95TqiHzlWVA3SxJgL0qWCjHFRHUTd2s3HEFiKCCcYPKVMR2y60u 3nuQ9dnxBIRSl+LCKG60br4TSmjpmftXeJw5+P+TGUT8rMvcnpJARj5gzEGP+8YddTAse5Q N8JFW6JBCPxWNEuSgImzomprOWA8pRdO8wO3HZ1sLLHsN3hAx4cpZzUy5hryV/vn0jlZRfM 2ld+65XN3Dn6byctbQVuQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:RPV9h+nMpJ4=:JlYAeu5ohQYaMWZd1MFNCj 8uGJIIanpvu8mUGuL/bOc4naDbISCz4MrIkBRjG/75Kqx0AScq+r9ZD6O+d8nyGFpZL4n5yNY iCVpLk02vIpFKrXKL6IFQazSByeF/qPkFw4TgzMKxCBqlZr4KAWrUTLk3Pne/IgDCLNrm2WJe 0G4Xg7E02aS1ukLzg5fy56FS5gd1M3KY5vj8ICY6vZ+sSkGodK5aOAR02GnMxxtA698MJquL8 f/E0xc+bH+rdMgPJJcmID6J+G7W/oNYEaic5cLEFBr6eyWCWgrOn8HjDFV3GhtZnKO9RNgDZG EHUZikoEF02mNEmLPlGlXci9h9KeROHBzP8iaXr8Gxm7FogfSGhUj7rJRe7a/Ctu9iNyfQIZU gY01BzBP0bvQI9NE8YeyoO7L4H8GkTtVp4qDiheitbwK0lzBloZKvgESgsESTlfFWPJ2b/Qs1 Xm4wy9/VpTUY4NhxVLm8wmQxnk2QrpOfbnafuK6VjgxN06I2/Zscur4HsJqTu+NIBQ93uEGHo q7ZsNJkyhqUvc/xVDNHkB45x5fFtB4Z9vV2HlJoB6k+F9ebLKop/6gmGKjSwK16zLUF4KRw8q qcGib1U3rRQSAemmqv4X/XYbbxFhd8UfpU4GY9HK3COsnj7h9biwFi045cNQhjHVzbtGgpcNk hwxlmWVH2S6l5G4GcO1EVLE/yMKKlr6BnZBEJjsH6ctaT1Qx3L5A/63I658HuTskBLeln7H+/ IZNj0vljQ8miA7VT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday, September 4, 2016 2:52:21 PM CEST Baoyou Xie wrote: > We get a few warnings when building kernel with W=1: > drivers/scsi/bnx2fc/bnx2fc_els.c:257:6: warning: no previous prototype for 'bnx2fc_srr_compl' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_els.c:367:6: warning: no previous prototype for 'bnx2fc_rec_compl' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:628:5: warning: no previous prototype for 'bnx2fc_percpu_io_thread' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_fcoe.c:1413:26: warning: no previous prototype for 'bnx2fc_interface_create' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_hwi.c:997:21: warning: no previous prototype for 'bnx2fc_alloc_work' [-Wmissing-prototypes] > drivers/scsi/bnx2fc/bnx2fc_io.c:1082:5: warning: no previous prototype for 'bnx2fc_abts_cleanup' [-Wmissing-prototypes] > .... > > In fact, these functions are only used in the file in which they are > declared and don't need a declaration, but can be made static. > so this patch marks these functions with 'static'. > > Signed-off-by: Baoyou Xie > Acked-by: Arnd Bergmann