All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luc Goria" <Luc.Goria@adept-telecom.fr>
To: <netdev@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>, <alan@redhat.com>
Subject: [PATCH 2.6.27.2] datagram handling routines : mapping/unmapping paged data in soft IRQ
Date: Mon, 11 May 2009 15:32:21 +0200	[thread overview]
Message-ID: <54466B0E862D654998371DCA86B6FE2F4B6D47@adept-srv2.adept.local> (raw)

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]


Kernel crashes when a network module tries to copy a datagram to iovec in soft IRQ with paged data.
The problem is that kunmap function can't be called in IRQ.
All calls to kmap/kunmap fonctions are replaced by calls to kmap_skb_frag/kunmap_skb_frag when paged data are involved.

 <<datagram.c.patch>> 
Signed-off-by: Luc GORIA <luc.goria@adept-telecom.fr>

[-- Attachment #2: datagram.c.patch --]
[-- Type: application/octet-stream, Size: 1623 bytes --]

--- linux-2.6.27.2/net/core/datagram.c	2009-05-06 17:43:08.000000000 +0200
+++ my-linux-2.6.27.2/net/core/datagram.c	2009-05-06 17:52:44.000000000 +0200
@@ -56,6 +56,8 @@
 #include <net/sock.h>
 #include <net/tcp_states.h>
 
+#include "kmap_skb.h"
+
 /*
  *	Is a socket 'connection oriented' ?
  */
@@ -292,14 +294,13 @@
 			int err;
 			u8  *vaddr;
 			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
-			struct page *page = frag->page;
 
 			if (copy > len)
 				copy = len;
-			vaddr = kmap(page);
+			vaddr = kmap_skb_frag(frag);
 			err = memcpy_toiovec(to, vaddr + frag->page_offset +
 					     offset - start, copy);
-			kunmap(page);
+			kunmap_skb_frag(vaddr);
 			if (err)
 				goto fault;
 			if (!(len -= copy))
@@ -377,14 +378,13 @@
 			int err;
 			u8  *vaddr;
 			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
-			struct page *page = frag->page;
 
 			if (copy > len)
 				copy = len;
-			vaddr = kmap(page);
+			vaddr = kmap_skb_frag(frag);
 			err = memcpy_fromiovec(vaddr + frag->page_offset +
 					       offset - start, from, copy);
-			kunmap(page);
+			kunmap_skb_frag(vaddr);
 			if (err)
 				goto fault;
 
@@ -461,16 +461,15 @@
 			int err = 0;
 			u8  *vaddr;
 			skb_frag_t *frag = &skb_shinfo(skb)->frags[i];
-			struct page *page = frag->page;
 
 			if (copy > len)
 				copy = len;
-			vaddr = kmap(page);
+			vaddr = kmap_skb_frag(frag);
 			csum2 = csum_and_copy_to_user(vaddr +
 							frag->page_offset +
 							offset - start,
 						      to, copy, 0, &err);
-			kunmap(page);
+			kunmap_skb_frag(vaddr);
 			if (err)
 				goto fault;
 			*csump = csum_block_add(*csump, csum2, pos);

             reply	other threads:[~2009-05-11 13:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-11 13:32 Luc Goria [this message]
2009-05-11 23:36 ` [PATCH 2.6.27.2] datagram handling routines : mapping/unmapping paged data in soft IRQ David Miller
2009-05-12  8:48 Luc Goria
2009-05-13  5:09 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54466B0E862D654998371DCA86B6FE2F4B6D47@adept-srv2.adept.local \
    --to=luc.goria@adept-telecom.fr \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.