From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34027)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Xi0aJ-0007B2-6B
	for qemu-devel@nongnu.org; Sat, 25 Oct 2014 08:36:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Xi0aB-0001jH-NB
	for qemu-devel@nongnu.org; Sat, 25 Oct 2014 08:36:43 -0400
Message-ID: <544B9773.1020903@web.de>
Date: Sat, 25 Oct 2014 14:28:35 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <1413844443-28894-1-git-send-email-knut.omang@oracle.com>
	<1413844443-28894-3-git-send-email-knut.omang@oracle.com>
In-Reply-To: <1413844443-28894-3-git-send-email-knut.omang@oracle.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="1ubKIJcsuIQNPqxVeRJesBK6tdbdV29MJ"
Subject: Re: [Qemu-devel] [PATCH 2/2] intel_iommu: Add support for
 translation for devices behind bridges.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Knut Omang <knut.omang@oracle.com>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.a@redhat.com>, Michael Tokarev <mjt@tls.msk.ru>, "Michael S. Tsirkin" <mst@redhat.com>, Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>, Alexander Graf <agraf@suse.de>, Markus Armbruster <armbru@redhat.com>, =?ISO-8859-15?Q?Andreas_F=E4rber?= <andreas.faerber@web.de>, =?ISO-8859-15?Q?Herv=E9_Poussineau?= <hpoussin@reactos.org>, Anthony Liguori <aliguori@amazon.com>, Stefan Weil <sw@weilnetz.de>, qemu-ppc@nongnu.org, Richard Henderson <rth@twiddle.net>

This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--1ubKIJcsuIQNPqxVeRJesBK6tdbdV29MJ
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable

On 2014-10-21 00:34, Knut Omang wrote:
> @@ -1801,8 +1792,7 @@ static IOMMUTLBEntry vtd_iommu_translate(MemoryRe=
gion *iommu, hwaddr addr,
>          return ret;
>      }
> =20
> -    vtd_do_iommu_translate(vtd_as, vtd_as->bus_num, vtd_as->devfn, add=
r,
> -                           is_write, &ret);
> +    vtd_do_iommu_translate(vtd_as, addr, is_write, &ret);
>      VTD_DPRINTF(MMU,
>                  "bus %"PRIu8 " slot %"PRIu8 " func %"PRIu8 " devfn %"P=
RIu8
>                  " gpa 0x%"PRIx64 " hpa 0x%"PRIx64, vtd_as->bus_num,

You need to update the VTD_DPRINTF as well when removing bus_num from
VTDAddressSpace.

Jan



--1ubKIJcsuIQNPqxVeRJesBK6tdbdV29MJ
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iEYEARECAAYFAlRLl3oACgkQitSsb3rl5xQeQQCfR4NpEpXaKd4XIh+5gnU88mJ6
sUIAnAiKccxwt6YvHVZy+e1DaILNlK0X
=HreT
-----END PGP SIGNATURE-----

--1ubKIJcsuIQNPqxVeRJesBK6tdbdV29MJ--