From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5E3BC433ED for ; Fri, 30 Apr 2021 14:07:32 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6E8AC61459 for ; Fri, 30 Apr 2021 14:07:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6E8AC61459 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:53380 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lcTnn-0007KZ-BQ for qemu-devel@archiver.kernel.org; Fri, 30 Apr 2021 10:07:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcTch-0004VT-82 for qemu-devel@nongnu.org; Fri, 30 Apr 2021 09:56:03 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:55361) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lcTcf-0003Ez-DT for qemu-devel@nongnu.org; Fri, 30 Apr 2021 09:56:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619790960; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hF/EIJgJvBrv102KMNDjsSOyDqSwvQu0LcCfAAjFRMM=; b=GDQ5I0Ss9L66PYcnodTJEADeOh1tIqrWv2KwJjGEXOZHCGwV/KU7UJdpGLK9zgglTV1Ozy mBj8407TMffs/BLjtSYrz00ceveocI5J+CcvQ9t7SFB0MaOCUWG/1zEVK75SDA1AFbbsP8 ZncrAhLk7dnfIMoHlCBTg6fvqILhrX8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-336-4RPaQ-YuPauzLiJJTrWLwA-1; Fri, 30 Apr 2021 09:55:58 -0400 X-MC-Unique: 4RPaQ-YuPauzLiJJTrWLwA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DB6C2107ACC7; Fri, 30 Apr 2021 13:55:57 +0000 (UTC) Received: from dresden.str.redhat.com (ovpn-114-68.ams2.redhat.com [10.36.114.68]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F8E42B1AA; Fri, 30 Apr 2021 13:55:55 +0000 (UTC) Subject: Re: [PATCH v3 15/15] docs/devel/testing: add -p option to the debug section of QEMU iotests To: Emanuele Giuseppe Esposito , qemu-block@nongnu.org References: <20210414170352.29927-1-eesposit@redhat.com> <20210414170352.29927-16-eesposit@redhat.com> From: Max Reitz Message-ID: <544b24e0-799e-c5d1-686b-9545a8b68218@redhat.com> Date: Fri, 30 Apr 2021 15:55:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210414170352.29927-16-eesposit@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mreitz@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=mreitz@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.22, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Eduardo Habkost , qemu-devel@nongnu.org, Cleber Rosa , Paolo Bonzini , John Snow Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 14.04.21 19:03, Emanuele Giuseppe Esposito wrote: > Signed-off-by: Emanuele Giuseppe Esposito > --- > docs/devel/testing.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/docs/devel/testing.rst b/docs/devel/testing.rst > index 62902cfd2d..0c18fc4571 100644 > --- a/docs/devel/testing.rst > +++ b/docs/devel/testing.rst > @@ -246,6 +246,10 @@ given as options to the ``check`` script: > * ``-d`` (debug) just increases the logging verbosity, showing > for example the QMP commands and answers. > > +* ``-p`` (print) allows QEMU binary stdout to be shown in the stderr, too. > + test console, instead of saving it into a log file in > + ``$TEST_DIR/qemu-machine-``. > + It doesn’t allow this, though, it forces it. That means that tests that use the log will fail (e.g. 245)[1]. That is, I’d drop the “allows” and just state “redirect QEMU’s stdout and stderr to the test output, instead of...”. [1] I realize that all tests will technically fail with -p, because the reference output differs, but 245 will not just fail because of that difference, but because two of its cases actually really fail. No need to make a note of this, though. It’s just that “allows” sounds a bit like qemu could choose to put some info into the test output and some into the log, when really it’s all or nothing (-p or not -p). Max > Test case groups > ---------------- > >