All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Wilck <mwilck@suse.com>
To: Lee Duncan <leeman.duncan@gmail.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Lee Duncan <lduncan@suse.com>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH] scsi: core: Add BLIST_NO_ASK_VPD_SIZE for some VDASD
Date: Thu, 29 Sep 2022 12:42:24 +0200	[thread overview]
Message-ID: <544cc60fd36647ee5257f2a863dbecb905095c51.camel@suse.com> (raw)
In-Reply-To: <20220928181350.9948-1-leeman.duncan@gmail.com>

On Wed, 2022-09-28 at 11:13 -0700, Lee Duncan wrote:
> From: Lee Duncan <lduncan@suse.com>
> 
> Some storage, such as AIX VDASD (virtual storage) and IBM 2076
> (front end) do not like the recent commit:
> 
> commit c92a6b5d6335 ("scsi: core: Query VPD size before getting full
> page")
> 
> That commit changed getting SCSI VPD pages so that we now read
> just enough of the page to get the actual page size, then read
> the whole page in a second read. The problem is that the above
> mentioned hardware returns zero for the page size, because of
> a firmware error. In such cases, until the firmware is fixed,
> this new black flag says to revert to the original method of
> reading the VPD pages, i.e. try to read as a whole buffer's
> worth on the first try.
> 
> Fixes: c92a6b5d6335 ("scsi: core: Query VPD size before getting full
> page")
> Reported-by: Martin Wilck <mwilck@suse.com>
> Suggested-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Lee Duncan <lduncan@suse.com>

Reviewed-by: Martin Wilck <mwilck@suse.com>

  reply	other threads:[~2022-09-29 10:42 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-28 18:13 [PATCH] scsi: core: Add BLIST_NO_ASK_VPD_SIZE for some VDASD Lee Duncan
2022-09-29 10:42 ` Martin Wilck [this message]
2022-10-02 21:16 ` Bart Van Assche
2022-10-02 22:21   ` Lee Duncan
2022-10-04  6:00   ` Hannes Reinecke
2022-11-08  2:50     ` Martin K. Petersen
2022-11-08  6:57       ` Hannes Reinecke
2022-11-21 14:53       ` Martin Wilck
2022-10-03 16:32 ` Bart Van Assche
2023-02-20 11:13 ` Srikar Dronamraju
2023-02-27  7:02 ` Hannes Reinecke
2023-03-03  9:02 ` Linux regression tracking (Thorsten Leemhuis)
2023-03-03 18:54   ` Lee Duncan
2023-03-06 22:14     ` Martin K. Petersen
2023-03-07  2:54     ` Martin K. Petersen
2023-03-07 10:32       ` Srikar Dronamraju
2023-03-07 16:33       ` Lee Duncan
2023-03-07 23:40         ` Martin K. Petersen
2023-03-08 18:41           ` Lee Duncan
2023-03-10  3:17             ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=544cc60fd36647ee5257f2a863dbecb905095c51.camel@suse.com \
    --to=mwilck@suse.com \
    --cc=hare@suse.de \
    --cc=jejb@linux.ibm.com \
    --cc=lduncan@suse.com \
    --cc=leeman.duncan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.