From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51C9E6EC7F for ; Wed, 19 May 2021 07:01:43 +0000 (UTC) References: <20210512170536.4778-1-bhanuprakash.modem@intel.com> <20210512170536.4778-12-bhanuprakash.modem@intel.com> From: "Nautiyal, Ankit K" Message-ID: <544e3df9-a914-3172-98dc-3fb728a7ae06@intel.com> Date: Wed, 19 May 2021 12:31:38 +0530 MIME-Version: 1.0 In-Reply-To: <20210512170536.4778-12-bhanuprakash.modem@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [v6 i-g-t 11/14] tests/kms_plane_lowres: Reset the state before exiting the test List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Bhanuprakash Modem , igt-dev@lists.freedesktop.org List-ID: LGTM. Reviewed-by: Ankit Nautiyal On 5/12/2021 10:35 PM, Bhanuprakash Modem wrote: > Before starting the next subtest, clean up the states to default > values, those are assumed by other tests. This patch will also fix > few redundant checks. > > Cc: Imre Deak > Cc: Ankit Nautiyal > Cc: Daniel Vetter > Signed-off-by: Bhanuprakash Modem > --- > tests/kms_plane_lowres.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/tests/kms_plane_lowres.c b/tests/kms_plane_lowres.c > index 5cfe53c8b..95346e289 100644 > --- a/tests/kms_plane_lowres.c > +++ b/tests/kms_plane_lowres.c > @@ -270,16 +270,13 @@ test_planes_on_pipe(data_t *data, uint64_t modifier) > igt_info("Testing connector %s using pipe %s\n", > igt_output_name(data->output), kmstest_pipe_name(data->pipe)); > > - for_each_plane_on_pipe(&data->display, data->pipe, plane) { > - data->output = igt_get_single_output_for_pipe(&data->display, data->pipe); > - igt_require(data->output); > - > + for_each_plane_on_pipe(&data->display, data->pipe, plane) > tested += test_planes_on_pipe_with_output(data, plane, modifier); > - } > > - igt_assert(tested > 0); > igt_output_set_pipe(data->output, PIPE_NONE); > igt_display_commit2(&data->display, COMMIT_ATOMIC); > + > + igt_assert(tested > 0); > } > > igt_main _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev