From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 07/23] drm/i915/gt: Move the [class][inst] lookup for engines onto the GT
Date: Fri, 26 Jul 2019 10:51:01 +0100 [thread overview]
Message-ID: <5454f79a-fa15-a811-6cb4-20e7177d7c32@linux.intel.com> (raw)
In-Reply-To: <156413359650.30723.4362365063332311124@skylake-alporthouse-com>
On 26/07/2019 10:33, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2019-07-26 10:22:08)
>>
>> On 23/07/2019 19:38, Chris Wilson wrote:
>> I read it, relatively rushed, since pressure keeps getting applied! :/
>>
>> There are some good parts and implementation looks okay, but I am not
>> sure we need a tree. Nodes are bigger than pointers, management code is
>> bigger, lookup is slower.. is it a win all things considered?
>
> A big win imo. Consider that this interface is purely debug, the primary
> interface runtime will be via gt->engines, the nodes are much smaller
> than the sparse array.
I guess it depends. One rb_node is three pointers and can only be used
from a single tree. Nor does the patch replaces all sparse arrays.
> I am adamant that we are not adding more sparse arrays. A 2D lookup
> table since that matches the HW, but even then we may just end up with
> LUT (1 extra pointer load to replace the sparse array with a compact?)
I feel it's too early for this specific patch.
Regards,
Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-07-26 9:51 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 18:38 [PATCH 01/23] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Chris Wilson
2019-07-23 18:38 ` [PATCH 02/23] drm/i915/gt: Provide a local intel_context.vm Chris Wilson
2019-07-23 18:38 ` [PATCH 03/23] drm/i915: Remove lrc default desc from GEM context Chris Wilson
2019-07-24 9:20 ` Tvrtko Ursulin
2019-08-01 8:37 ` Tvrtko Ursulin
2019-08-01 8:41 ` Chris Wilson
2019-08-01 8:53 ` Tvrtko Ursulin
2019-08-01 10:57 ` Chris Wilson
2019-08-01 11:13 ` Chris Wilson
2019-08-01 15:29 ` Tvrtko Ursulin
2019-08-01 15:48 ` Chris Wilson
2019-08-01 16:00 ` Chris Wilson
2019-08-01 16:22 ` Tvrtko Ursulin
2019-08-01 16:36 ` Chris Wilson
2019-07-23 18:38 ` [PATCH 04/23] drm/i915: Push the ring creation flags to the backend Chris Wilson
2019-07-24 11:11 ` Tvrtko Ursulin
2019-07-26 8:43 ` Chris Wilson
2019-07-29 12:59 ` Tvrtko Ursulin
2019-07-30 9:38 ` Chris Wilson
2019-08-01 8:42 ` Tvrtko Ursulin
2019-08-01 8:45 ` Chris Wilson
2019-08-01 8:46 ` Chris Wilson
2019-07-23 18:38 ` [PATCH 05/23] drm/i915: Flush extra hard after writing relocations through the GTT Chris Wilson
2019-07-23 18:38 ` [PATCH 06/23] drm/i915: Hide unshrinkable context objects from the shrinker Chris Wilson
2019-07-23 18:38 ` [PATCH 07/23] drm/i915/gt: Move the [class][inst] lookup for engines onto the GT Chris Wilson
2019-07-25 21:21 ` Daniele Ceraolo Spurio
2019-07-26 9:22 ` Tvrtko Ursulin
2019-07-26 9:33 ` Chris Wilson
2019-07-26 9:51 ` Tvrtko Ursulin [this message]
2019-07-26 9:57 ` Chris Wilson
2019-07-23 18:38 ` [PATCH 08/23] drm/i915: Introduce for_each_user_engine() Chris Wilson
2019-07-23 18:38 ` [PATCH 09/23] drm/i915: Use intel_engine_lookup_user for probing HAS_BSD etc Chris Wilson
2019-07-23 18:38 ` [PATCH 10/23] drm/i915: Isolate i915_getparam_ioctl() Chris Wilson
2019-07-23 18:38 ` [PATCH 11/23] drm/i915: Only include active engines in the capture state Chris Wilson
2019-07-23 18:38 ` [PATCH 12/23] drm/i915: Teach execbuffer to take the engine wakeref not GT Chris Wilson
2019-07-23 18:38 ` [PATCH 13/23] drm/i915/gt: Track timeline activeness in enter/exit Chris Wilson
2019-07-23 18:38 ` [PATCH 14/23] drm/i915/gt: Convert timeline tracking to spinlock Chris Wilson
2019-07-23 18:38 ` [PATCH 15/23] drm/i915/gt: Guard timeline pinning with its own mutex Chris Wilson
2019-07-23 18:38 ` [PATCH 16/23] drm/i915/gt: Add to timeline requires the timeline mutex Chris Wilson
2019-07-23 18:38 ` [PATCH 17/23] drm/i915: Protect request retirement with timeline->mutex Chris Wilson
2019-07-23 18:38 ` [PATCH 18/23] drm/i915: Replace struct_mutex for batch pool serialisation Chris Wilson
2019-07-23 18:38 ` [PATCH 19/23] drm/i915/gt: Mark context->active_count as protected by timeline->mutex Chris Wilson
2019-07-23 18:38 ` [PATCH 20/23] drm/i915: Forgo last_fence active request tracking Chris Wilson
2019-07-23 18:38 ` [PATCH 21/23] drm/i915/overlay: Switch to using i915_active tracking Chris Wilson
2019-07-23 18:38 ` [PATCH 22/23] drm/i915: Extract intel_frontbuffer active tracking Chris Wilson
2019-07-23 18:38 ` [PATCH 23/23] drm/i915: Markup expected timeline locks for i915_active Chris Wilson
2019-07-23 20:16 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/23] drm/i915: Move aliasing_ppgtt underneath its i915_ggtt Patchwork
2019-07-23 20:27 ` ✗ Fi.CI.SPARSE: " Patchwork
2019-07-23 20:38 ` ✓ Fi.CI.BAT: success " Patchwork
2019-07-24 4:13 ` ✗ Fi.CI.IGT: failure " Patchwork
2019-07-24 8:56 ` [PATCH 01/23] " Tvrtko Ursulin
2019-07-24 9:27 ` Chris Wilson
2019-07-24 9:37 ` Chris Wilson
2019-07-24 9:47 ` Chris Wilson
2019-07-24 9:54 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5454f79a-fa15-a811-6cb4-20e7177d7c32@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.