From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dave Gordon <david.s.gordon@intel.com>
Subject: Re: [PATCH] drm/i915: Reduce duplicated forcewake logic
Date: Fri, 07 Nov 2014 18:55:22 +0000
Message-ID: <545D159A.3080702@intel.com>
References: <20140910155116.GD31074@nuc-i3427.alporthouse.com>
 <1410374094-5210-1-git-send-email-chris@chris-wilson.co.uk>
 <20141107154655.GY10649@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by gabe.freedesktop.org (Postfix) with ESMTP id 3AA696EDD2
 for <intel-gfx@lists.freedesktop.org>; Fri,  7 Nov 2014 10:55:36 -0800 (PST)
In-Reply-To: <20141107154655.GY10649@intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org, Chris Wilson <chris@chris-wilson.co.uk>
List-Id: intel-gfx@lists.freedesktop.org

T24gMDcvMTEvMTQgMTU6NDYsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiBPbiBXZWQsIFNlcCAx
MCwgMjAxNCBhdCAwNzozNDo1NFBNICswMTAwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+IEludHJv
ZHVjZSBhIHN0cnVjdHVyZSB0byB0cmFjayB0aGUgaW5kaXZpZHVhbCBmb3JjZXdha2UgZG9tYWlu
cyBhbmQgdXNlCj4+IHRoYXQgdG8gZWxpbWluYXRlZCBkdXBsaWNhdGUgbG9naWMuCj4+IC0tLQo+
PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgfCAgNDEgKysrLS0tCj4+ICBk
cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICB8ICAzMiArKystLQo+PiAgZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMgfCAyNjUgKysrKysrKysrKysrKysrKy0tLS0t
LS0tLS0tLS0tLS0tLS0tCj4+ICAzIGZpbGVzIGNoYW5nZWQsIDE1NyBpbnNlcnRpb25zKCspLCAx
ODEgZGVsZXRpb25zKC0pCgpIaSBDaHJpcywKCnRoaXMgbG9va3MgdXNlZnVsIC0tIEkgd2FzIGxv
b2tpbmcgYXQgcmVmYWN0b3JpbmcgdGhlIFZMViB2cyBHRU45CnZlcnNpb25zIG9mIGZvcmNld2Fr
ZSB0b28uIEEgZmV3IGNvbW1lbnRzIGJlbG93OgoKPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1
L2RybS9pOTE1L2ludGVsX3VuY29yZS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdW5j
b3JlLmMKPj4gaW5kZXggM2IzZDNlMC4uNjQxOTUwYiAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9n
cHUvZHJtL2k5MTUvaW50ZWxfdW5jb3JlLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfdW5jb3JlLmMKCj4+IEBAIC0xNDUsNyArMTQ1LDcgQEAgc3RhdGljIHZvaWQgX19nZW42
X2d0X2ZvcmNlX3dha2VfcHV0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4g
IH0KPj4gIAo+PiAgc3RhdGljIHZvaWQgX19nZW43X2d0X2ZvcmNlX3dha2VfbXRfcHV0KHN0cnVj
dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4gLQkJCQkJCQlpbnQgZndfZW5naW5lKQo+
PiArCQkJCQlpbnQgZndfZW5naW5lKQoKSGVyZSBhbmQgaW4gYWxsIHRoZSBvdGhlciB2ZXJzaW9u
czogaG93IGFib3V0IHJlbmFtaW5nIHRoZSBwYXJhbWV0ZXIgdG8KImZ3X2RvbWFpbnMiIGluIGxp
bmUgd2l0aCB5b3VyIG5ldyBlbnVtIGFuZCBzdHJ1Y3QgbmFtaW5nPyBUaHVzIG1ha2luZwppdCBj
bGVhcmVyIHRoYXQgaXQgY2FuIGhhdmUgbXVsdGlwbGUgYml0cyBzZXQgLi4uCgo+PiBAQCAtMzg5
LDUwICszNTgsNjAgQEAgdm9pZCBpbnRlbF91bmNvcmVfc2FuaXRpemUoc3RydWN0IGRybV9kZXZp
Y2UgKmRldikKPj4gICAqIGJlIGNhbGxlZCBhdCB0aGUgYmVnaW5uaW5nIG9mIHRoZSBzZXF1ZW5j
ZSBmb2xsb3dlZCBieSBhIGNhbGwgdG8KPj4gICAqIGdlbjZfZ3RfZm9yY2Vfd2FrZV9wdXQoKSBh
dCB0aGUgZW5kIG9mIHRoZSBzZXF1ZW5jZS4KPj4gICAqLwo+PiAtdm9pZCBnZW42X2d0X2ZvcmNl
X3dha2VfZ2V0KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwgaW50IGZ3X2VuZ2lu
ZSkKPj4gK3ZvaWQgZ2VuNl9ndF9mb3JjZV93YWtlX2dldChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0
ZSAqZGV2X3ByaXYsCj4+ICsJCQkgICAgdW5zaWduZWQgZndfZG9tYWlucykKPj4gIHsKPj4gIAl1
bnNpZ25lZCBsb25nIGlycWZsYWdzOwo+PiArCWludCBpOwo+PiAgCj4+ICAJaWYgKCFkZXZfcHJp
di0+dW5jb3JlLmZ1bmNzLmZvcmNlX3dha2VfZ2V0KQo+PiAgCQlyZXR1cm47Cj4+ICAKPj4gIAlX
QVJOX09OKCFwbV9ydW50aW1lX2FjdGl2ZSgmZGV2X3ByaXYtPmRldi0+cGRldi0+ZGV2KSk7Cj4+
ICAKPj4gKwlmd19kb21haW5zICY9IGRldl9wcml2LT51bmNvcmUuZndfZG9tYWluczsKPj4gKwo+
PiAgCXNwaW5fbG9ja19pcnFzYXZlKCZkZXZfcHJpdi0+dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsK
Pj4gIAo+PiAtCS8qIFJlZGlyZWN0IHRvIFZMViBzcGVjaWZpYyByb3V0aW5lICovCj4+IC0JaWYg
KElTX1ZBTExFWVZJRVcoZGV2X3ByaXYtPmRldikpIHsKPj4gLQkJdmx2X2ZvcmNlX3dha2VfZ2V0
KGRldl9wcml2LCBmd19lbmdpbmUpOwo+PiAtCX0gZWxzZSB7Cj4+IC0JCWlmIChkZXZfcHJpdi0+
dW5jb3JlLmZvcmNld2FrZV9jb3VudCsrID09IDApCj4+IC0JCQlkZXZfcHJpdi0+dW5jb3JlLmZ1
bmNzLmZvcmNlX3dha2VfZ2V0KGRldl9wcml2LAo+PiAtCQkJCQkJCSAgICAgIEZPUkNFV0FLRV9B
TEwpOwo+PiArCWZvciAoaSA9IDA7IGkgPCBGV19ET01BSU5fQ09VTlQ7IGkrKykgewo+PiArCQlp
ZiAoKGZ3X2RvbWFpbnMgJiAoMSA8PCBpKSkgPT0gMCkKPj4gKwkJCWNvbnRpbnVlOwo+PiArCj4+
ICsJCWlmIChkZXZfcHJpdi0+dW5jb3JlLmZ3X2RvbWFpbltpXS53YWtlX2NvdW50KyspCj4+ICsJ
CQlmd19kb21haW5zICY9IH4oMSA8PCBpKTsKPj4gIAl9Cj4+ICsKPj4gKwlpZiAoZndfZG9tYWlu
cykKPj4gKwkJZGV2X3ByaXYtPnVuY29yZS5mdW5jcy5mb3JjZV93YWtlX2dldChkZXZfcHJpdiwg
ZndfZG9tYWlucyk7Cj4+ICsKPj4gIAlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXZfcHJpdi0+
dW5jb3JlLmxvY2ssIGlycWZsYWdzKTsKPj4gIH0KCk5pY2UgdG8gZ2V0IHJpZCBvZiB0aGUgIlJl
ZGlyZWN0IHRvIFhYWCBzcGVjaWZpYyByb3V0aW5lIiBzdHVmZiAtLSBvbmUKb2YgdGhlIHRoaW5n
cyBJIGRvbid0IGxpa2UgYWJvdXQgdGhlIGN1cnJlbnQgZm9yY2V3YWtlIGNvZGUgaXMgdGhhdCB0
aGUKVkxWIGFuZCBHRU45IHZlcnNpb25zIG9mIHRoZSBvdXRlciB3cmFwcGVyIGFyZSBpbmNvbnNp
c3RlbnQgdy5yLnQuIGhvdwooYW5kIGhvdyBtYW55IHRpbWVzKSB0byBjYWxsIHRoZSAtPmZvcmNl
X3dhaXRfZ2V0KCkgdmZ1bmMgLS0gdmx2CmNvbGxlY3RzIGFsbCB0aGUgYml0cyBhbmQgbWFrZXMg
b25lIGNhbGwsIGdlbjkgbWFrZXMgb25lIGNhbGwgZm9yIGVhY2gKYml0IHNlcGFyYXRlbHkuIFRo
aXMgY29kZSB3b3VsZCBoYW5kbGUgYWxsIGdlbnMgY29uc2lzdGVudGx5LCB3aGljaCBpcwptdWNo
IG5pY2VyLiBBbmQgSSBwcmVmZXIgYSBzaW5nbGUgY2FsbCB3aXRoIG11bHRpcGxlIGJpdHMsIHNv
IHRoYXQgdGhlCmxvdy1sZXZlbCBjb2RlLCB3aGljaCBrbm93cyB3aGVyZSB0aGUgY29ycmVzcG9u
ZGluZyBoL3cgYml0cyBhcmUsIGNhbgpkZWFsIGVmZmljaWVudGx5IHdpdGggbXVsdGlwbGUgYml0
cyBtYXBwaW5nIHRvIHRoZSBzYW1lIHJlZ2lzdGVyLCBvcgooZm9yIGV4YW1wbGUpIGlzc3VlIGFs
bCB0aGUgZm9yY2V3YWtlIHdyaXRlcyBmaXJzdCBhbmQgdGhlbiBwb2xsIHRoZW0KYWxsIGZvciBj
b21wbGV0aW9uLCByYXRoZXIgdGhhbiBkb2luZyB0aGUgd3JpdGUvcG9sbCBwYWlycyBzZXF1ZW50
aWFsbHkuCgpbc25pcF0KPiAKPiBBbHNvIHRoZSBjb2RlIGluIG5pZ2h0bHkgc3RpbGwgaGFzIHRo
ZSBydW50aW1lIHBtIHN0dWZmIGluIHRoZSBmb3JjZXdha2UKPiBjb2RlLiBJIGd1ZXNzIHlvdSBj
bGVhbmVkIHRob3NlIG91dCBpbiB5b3VyIHRyZWUsIGJ1dCBJIGRvbid0IHJlbWViZXIKPiBzZWVp
bmcgYSByZWNlbnQgcGF0Y2ggb24gdGhhdCBmcm9udC4KClllcywgdGhpcyBoYXMgYmVlbiBhbm90
aGVyIGFyZWEgd2Ugd2FudGVkIGNsYXJpZmllZCBhbmQvb3IgdGlkaWVkIHVwIHRvbwotIEkgcG9z
dGVkIGEgbWVzc2FnZSBlYXJsaWVyIHRvZGF5IGFza2luZyBhYm91dCB3aGV0aGVyIHRoZSBQTSBj
YWxscwp3ZXJlIG5lY2Vzc2FyeSBhbmQgYSBwYXRjaCB0aGF0IGFsbG93ZWQgdGhlbSB0byBiZSBh
dm9pZGVkLiBCdXQgaWYgdGhleQpjYW4gYmUgcmVtb3ZlZCBjb21wbGV0ZWx5IHRoYXQgd291bGQg
YmUgYmV0dGVyIHN0aWxsIDopCgo+IE90aGVyd2lzZSB0aGlzIGxvb2tkIHZlcnkgbmljZSBJTU8s
IHNvIHdvdWxkIGJlIGdyZWF0IHRvIGdldCBpdCBpbgo+IGZpbmFsbHkuCgpBZ3JlZWQgLQouRGF2
ZS4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt
Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s
aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK