Re: [meta-oe][V2 patch] rrdtool: allow configuration to disable nls

[Randy MacLeod <randy.macleod@windriver.com>]

On 2017-05-28 09:12 PM, Randy MacLeod wrote:
> 
> Martin,
> 
> You've merged v1:
>     [oe] [meta-oe][PATCH] rrdtool: add gettext-native dependency

err I mean, you've merged v1 to master-next to be clear.
../Randy

> Could you drop that for this fix since it's a somewhat better approach.
> 
> ../Randy
> 
> On 2017-05-17 10:07 PM, Randy MacLeod wrote:
>> When building rrdtool for a 'tiny' distro, that does not have native
>> language support (NLS) in glibc, configure fails with the error:
>>     autoreconf: failed to run autopoint: No such file or directory
>> Autopoint is part of gettext but without NLS support we populate the
>> sysroot with gettext-minimal-native rather then the full set of
>> gettext executables. This version does not install autopoint, nor
>> should it.
>>
>> Tell autoreconf to skip the check for the autopoint script
>> regardless of NLS support and use the USE_NLS varible
>> to conditionally enable NLS support.
>>
>> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>> ---
>>   meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb 
>> b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb
>> index db2df28a0..3ccefb995 100644
>> --- a/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb
>> +++ b/meta-oe/recipes-extended/rrdtool/rrdtool_1.6.0.bb
>> @@ -22,7 +22,7 @@ BBCLASSEXTEND = "native"
>>   SYSTEMD_PACKAGES = "rrdcached"
>>   SYSTEMD_SERVICE_rrdcached = "rrdcached.socket rrdcached.service"
>> -EXTRA_AUTORECONF = "-I m4"
>> +EXTRA_AUTORECONF = "-I m4 --exclude=autopoint"
>>   PACKAGECONFIG ??= "python perl ${@bb.utils.filter('DISTRO_FEATURES', 
>> 'systemd', d)}"
>> @@ -49,6 +49,7 @@ EXTRA_OECONF = " \
>>       --disable-lua \
>>       --disable-tcl \
>>       --disable-rpath \
>> +    --enable-nls=${USE_NLS} \
>>   "
>>   export STAGING_LIBDIR
>>
> 
> 


-- 
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350 | 350 Terry Fox Drive, Suite 200, Ottawa, ON, 
Canada, K2K 2W5