From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F41EC4361B for ; Wed, 9 Dec 2020 08:21:39 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D9A7323B87 for ; Wed, 9 Dec 2020 08:21:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D9A7323B87 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.48025.84946 (Exim 4.92) (envelope-from ) id 1kmuiw-0002up-6z; Wed, 09 Dec 2020 08:21:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 48025.84946; Wed, 09 Dec 2020 08:21:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmuiw-0002ui-3E; Wed, 09 Dec 2020 08:21:22 +0000 Received: by outflank-mailman (input) for mailman id 48025; Wed, 09 Dec 2020 08:21:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kmuiv-0002ud-Cq for xen-devel@lists.xenproject.org; Wed, 09 Dec 2020 08:21:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 4a50152d-9972-4d03-8093-91d06f3869d7; Wed, 09 Dec 2020 08:21:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 08D66AC94; Wed, 9 Dec 2020 08:21:19 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 4a50152d-9972-4d03-8093-91d06f3869d7 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1607502079; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BR6OrlxOK2RJx/adT+RYdSKkeSPh4Laeq9svf64qL4g=; b=LmlvQZfMK5mvaPD0MltX3k9qTurzaUI0cza4yMWsgkB6oLg1qF39uszypauhZHBJCM+pSG u9HbpPyPtTmVnqzuAi2uE/ynpkFsEsKf034mWLUN3FT5Zw4V30OaxYKoTmVi01FvL8oROB dXTKTNL3RGni8Tubr+wKRMwqhlsKdKA= Subject: Re: [PATCH V3 20/23] xen/ioreq: Make x86's send_invalidate_req() common To: Oleksandr Cc: Oleksandr Tyshchenko , Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , Wei Liu , George Dunlap , Ian Jackson , Julien Grall , Stefano Stabellini , Paul Durrant , Julien Grall , xen-devel@lists.xenproject.org References: <1606732298-22107-1-git-send-email-olekstysh@gmail.com> <1606732298-22107-21-git-send-email-olekstysh@gmail.com> From: Jan Beulich Message-ID: <545e71ec-7168-3a45-3c21-82d839481d03@suse.com> Date: Wed, 9 Dec 2020 09:21:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08.12.2020 17:49, Oleksandr wrote: > On 08.12.20 17:24, Jan Beulich wrote: >> On 30.11.2020 11:31, Oleksandr Tyshchenko wrote: >>> --- a/xen/include/xen/sched.h >>> +++ b/xen/include/xen/sched.h >>> @@ -552,6 +552,8 @@ struct domain >>> struct ioreq_server *server[MAX_NR_IOREQ_SERVERS]; >>> unsigned int nr_servers; >>> } ioreq_server; >>> + >>> + bool mapcache_invalidate; >>> #endif >>> }; >> While I can see reasons to put this inside the #ifdef here, I >> would suspect putting it in the hole next to the group of 5 >> bools further up would be more efficient. > > ok, will put (although it will increase the number of #ifdef) I was implying no #ifdef in this case, suitably justified by half a sentence in the patch description. Jan