From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 001D2C433DF for ; Thu, 30 Jul 2020 21:22:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D788820838 for ; Thu, 30 Jul 2020 21:22:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730640AbgG3VWI (ORCPT ); Thu, 30 Jul 2020 17:22:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34060 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730551AbgG3VWG (ORCPT ); Thu, 30 Jul 2020 17:22:06 -0400 Received: from sipsolutions.net (s3.sipsolutions.net [IPv6:2a01:4f8:191:4433::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0ED2AC061574 for ; Thu, 30 Jul 2020 14:22:06 -0700 (PDT) Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) (envelope-from ) id 1k1G03-00Dkqx-HU; Thu, 30 Jul 2020 23:22:03 +0200 Message-ID: <54628f052b380e660c37cb9b7c3f224976aa1c83.camel@sipsolutions.net> Subject: Re: [PATCH v4 1/2] nl80211: Add FILS discovery support From: Johannes Berg To: Aloka Dixit Cc: linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org Date: Thu, 30 Jul 2020 23:22:02 +0200 In-Reply-To: <2b1ea1c4baedcb119f4e632b26399071@codeaurora.org> References: <20200618050427.5891-1-alokad@codeaurora.org> <20200618050427.5891-2-alokad@codeaurora.org> <2b1ea1c4baedcb119f4e632b26399071@codeaurora.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.4 (3.36.4-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Thu, 2020-07-30 at 14:17 -0700, Aloka Dixit wrote: > > OTOH, if it's with headers, how could it be optional? In fact, either > > way, how is it optional? > > > > Template has management frame headers as well. Will change the wording > accordingly. OK. > I made the template optional because FILS discovery may or may not be > offloaded to FW. But how would anyone know? Try without it, and then try again if that fails? Would it fail? I mean, you also said it was required at least for 6 GHz, so wouldn't userspace be better off always giving it - and then we should probably make it mandatory so it doesn't fall into the trap? However - and here that's my ignorance speaking - can it really be offloaded? I mean, is everything in there completely determined by the beacon already, and so you have no choice in how to build it? Or how does that work? > Yeah, I looked through existing examples for NLA_BINARY, those provide > only the higher bound for length. Yeah, no way to do anything else right now. But you should have a lower bound in the code, I think. > But I can modify it to range once that is added. Later maybe :) johannes