From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926AbaKLVvD (ORCPT ); Wed, 12 Nov 2014 16:51:03 -0500 Received: from mout.web.de ([212.227.15.14]:51555 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751865AbaKLVvA (ORCPT ); Wed, 12 Nov 2014 16:51:00 -0500 Message-ID: <5463D62D.3010206@users.sourceforge.net> Date: Wed, 12 Nov 2014 22:50:37 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Dan Carpenter CC: Greg Kroah-Hartman , devel@driverdev.osuosl.org, trivial@kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Coccinelle Subject: Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() References: <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> <20141112211438.GI6749@mwanda> In-Reply-To: <20141112211438.GI6749@mwanda> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Pfn5oI5wG4XoMw0o2enhNZdM6rqwcccM6t9oaTYeGLJyrBwmK1S qUL2hKjuD+mHvyT2dPXi1DEYox9f/3+thK3Fkgjohlhfs6WlO76kzDIubEWf6o3GaS322ge XWyXh8xMG2Mq/U/w6d5YtRjLpQET+wbXH6/F6eSHROLgapO7aXTXKUCgTTZc5JOnu2Clexz +pjUUK/REsh8Z85PIownA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> + goto cleanup1; > > 1) Don't use GW-BASIC label names. Label names should reflect what the > label does such as free_fuse_word or free_fuse_tabel. > > 2) Don't use do-nothing labels. Just return directly. Does the document "CodingStyle" need any extensions for special cases? Are there any update candidates in the chapter "7: Centralized exiting of functions"? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 12 Nov 2014 21:50:37 +0000 Subject: Re: [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() Message-Id: <5463D62D.3010206@users.sourceforge.net> List-Id: References: <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> <20141112211438.GI6749@mwanda> In-Reply-To: <20141112211438.GI6749@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr >> + goto cleanup1; > > 1) Don't use GW-BASIC label names. Label names should reflect what the > label does such as free_fuse_word or free_fuse_tabel. > > 2) Don't use do-nothing labels. Just return directly. Does the document "CodingStyle" need any extensions for special cases? Are there any update candidates in the chapter "7: Centralized exiting of functions"? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Wed, 12 Nov 2014 22:50:37 +0100 Subject: [Cocci] [PATCH v2 2/2] staging: rtl8188eu: Better memory clean-up in efuse_phymap_to_logical() In-Reply-To: <20141112211438.GI6749@mwanda> References: <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <544954FD.8040607@users.sourceforge.net> <20141029084702.GA18675@kroah.com> <5453CD0D.9010206@users.sourceforge.net> <5463C10D.6020409@users.sourceforge.net> <5463C373.5050804@users.sourceforge.net> <20141112211438.GI6749@mwanda> Message-ID: <5463D62D.3010206@users.sourceforge.net> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr >> + goto cleanup1; > > 1) Don't use GW-BASIC label names. Label names should reflect what the > label does such as free_fuse_word or free_fuse_tabel. > > 2) Don't use do-nothing labels. Just return directly. Does the document "CodingStyle" need any extensions for special cases? Are there any update candidates in the chapter "7: Centralized exiting of functions"? Regards, Markus