From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755466AbaKPQ5o (ORCPT ); Sun, 16 Nov 2014 11:57:44 -0500 Received: from mout.web.de ([212.227.15.14]:50832 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755217AbaKPQ5m (ORCPT ); Sun, 16 Nov 2014 11:57:42 -0500 Message-ID: <5468D774.60901@users.sourceforge.net> Date: Sun, 16 Nov 2014 17:57:24 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Julia Lawall CC: Ananth N Mavinakayanahalli , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Coccinelle Subject: Re: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546899CF.8020808@users.sourceforge.net> <5468B3FD.20409@users.sourceforge.net> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Q7QUbQqLX7Fj34MZbWdfTeFc2ywf0BEKN8Vgg4jtYz9JGCYGTQ7 7jOIPv2GN4+bN0hSDup0HGRvm4iHSRsvWsoBtr39+62lFbw4z0RQwYS6VMxeZUwGDyLnCv7 /Fdj4XremijB7eKXbmPuGOauDJzZKsnJrbE55E4UDAKOJU2b6LMFAchJwGq4gx813S1Nh3g w7heIq2jPq4Kx41ei7vSw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > The if around the module_put is helpful to the reader to understand > that this possibility exists. I have got a different opinion. I would still prefer a small code clean-up there. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Sun, 16 Nov 2014 16:57:24 +0000 Subject: Re: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_p Message-Id: <5468D774.60901@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546899CF.8020808@users.sourceforge.net> <5468B3FD.20409@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr > The if around the module_put is helpful to the reader to understand > that this possibility exists. I have got a different opinion. I would still prefer a small code clean-up there. Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Sun, 16 Nov 2014 17:57:24 +0100 Subject: [Cocci] [PATCH 1/1] kprobes: Deletion of an unnecessary check before the function call "module_put" In-Reply-To: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546899CF.8020808@users.sourceforge.net> <5468B3FD.20409@users.sourceforge.net> Message-ID: <5468D774.60901@users.sourceforge.net> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr > The if around the module_put is helpful to the reader to understand > that this possibility exists. I have got a different opinion. I would still prefer a small code clean-up there. Regards, Markus