From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 316A0C2BA83 for ; Thu, 13 Feb 2020 11:12:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0DD5620848 for ; Thu, 13 Feb 2020 11:12:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729845AbgBMLMv (ORCPT ); Thu, 13 Feb 2020 06:12:51 -0500 Received: from ivanoab7.miniserver.com ([37.128.132.42]:47738 "EHLO www.kot-begemot.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726232AbgBMLMv (ORCPT ); Thu, 13 Feb 2020 06:12:51 -0500 Received: from tun252.jain.kot-begemot.co.uk ([192.168.18.6] helo=jain.kot-begemot.co.uk) by www.kot-begemot.co.uk with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j2CQJ-00081T-WC; Thu, 13 Feb 2020 11:12:48 +0000 Received: from jain.kot-begemot.co.uk ([192.168.3.3]) by jain.kot-begemot.co.uk with esmtp (Exim 4.92) (envelope-from ) id 1j2CQH-0007rt-Ni; Thu, 13 Feb 2020 11:12:47 +0000 Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, Jason Wang , linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> From: Anton Ivanov Message-ID: <54692f06-f687-8bd3-7a1b-3dac3e79110b@cambridgegreys.com> Date: Thu, 13 Feb 2020 11:12:45 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200213045937-mutt-send-email-mst@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Clacks-Overhead: GNU Terry Pratchett Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 13/02/2020 10:00, Michael S. Tsirkin wrote: > On Wed, Feb 12, 2020 at 05:38:09PM +0000, Anton Ivanov wrote: >> >> >> On 11/02/2020 10:37, Michael S. Tsirkin wrote: >>> On Tue, Feb 11, 2020 at 07:42:37AM +0000, Anton Ivanov wrote: >>>> On 11/02/2020 02:51, Jason Wang wrote: >>>>> >>>>> On 2020/2/11 上午12:55, Anton Ivanov wrote: >>>>>> >>>>>> >>>>>> On 09/12/2019 10:48, anton.ivanov@cambridgegreys.com wrote: >>>>>>> From: Anton Ivanov >>>>>>> >>>>>>> Some of the frames marked as GSO which arrive at >>>>>>> virtio_net_hdr_from_skb() have no GSO_TYPE, no >>>>>>> fragments (data_len = 0) and length significantly shorter >>>>>>> than the MTU (752 in my experiments). >>>>>>> >>>>>>> This is observed on raw sockets reading off vEth interfaces >>>>>>> in all 4.x and 5.x kernels I tested. >>>>>>> >>>>>>> These frames are reported as invalid while they are in fact >>>>>>> gso-less frames. >>>>>>> >>>>>>> This patch marks the vnet header as no-GSO for them instead >>>>>>> of reporting it as invalid. >>>>>>> >>>>>>> Signed-off-by: Anton Ivanov >>>>>>> --- >>>>>>>   include/linux/virtio_net.h | 8 ++++++-- >>>>>>>   1 file changed, 6 insertions(+), 2 deletions(-) >>>>>>> >>>>>>> diff --git a/include/linux/virtio_net.h b/include/linux/virtio_net.h >>>>>>> index 0d1fe9297ac6..d90d5cff1b9a 100644 >>>>>>> --- a/include/linux/virtio_net.h >>>>>>> +++ b/include/linux/virtio_net.h >>>>>>> @@ -112,8 +112,12 @@ static inline int >>>>>>> virtio_net_hdr_from_skb(const struct sk_buff *skb, >>>>>>>               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV4; >>>>>>>           else if (sinfo->gso_type & SKB_GSO_TCPV6) >>>>>>>               hdr->gso_type = VIRTIO_NET_HDR_GSO_TCPV6; >>>>>>> -        else >>>>>>> -            return -EINVAL; >>>>>>> +        else { >>>>>>> +            if (skb->data_len == 0) >>>>>>> +                hdr->gso_type = VIRTIO_NET_HDR_GSO_NONE; >>>>>>> +            else >>>>>>> +                return -EINVAL; >>>>>>> +        } >>>>>>>           if (sinfo->gso_type & SKB_GSO_TCP_ECN) >>>>>>>               hdr->gso_type |= VIRTIO_NET_HDR_GSO_ECN; >>>>>>>       } else >>>>>>> >>>>>> >>>>>> ping. >>>>>> >>>>> >>>>> Do you mean gso_size is set but gso_type is not? Looks like a bug >>>>> elsewhere. >>>>> >>>>> Thanks >>>>> >>>>> >>>> Yes. >>>> >>>> I could not trace it where it is coming from. >>>> >>>> I see it when doing recvmmsg on raw sockets in the UML vector network >>>> drivers. >>>> >>> >>> I think we need to find the culprit and fix it there, lots of other things >>> can break otherwise. >>> Just printing out skb->dev->name should do the trick, no? >> >> The printk in virtio_net_hdr_from_skb says NULL. >> >> That is probably normal for a locally originated frame. >> >> I cannot reproduce this with network traffic by the way - it happens only if the traffic is locally originated on the host. >> >> A, > > OK so is it code in __tcp_transmit_skb that sets gso_size to non-null > when gso_type is 0? It does look like that, but I cannot see it when reading it :( > > >>> >>> >>>> -- >>>> Anton R. Ivanov >>>> Cambridgegreys Limited. Registered in England. Company Number 10273661 >>>> https://www.cambridgegreys.com/ >>> >>> >>> _______________________________________________ >>> linux-um mailing list >>> linux-um@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-um >>> >> >> -- >> Anton R. Ivanov >> Cambridgegreys Limited. Registered in England. Company Number 10273661 >> https://www.cambridgegreys.com/ > > -- Anton R. Ivanov Cambridgegreys Limited. Registered in England. Company Number 10273661 https://www.cambridgegreys.com/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ivanoab7.miniserver.com ([37.128.132.42] helo=www.kot-begemot.co.uk) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2CQL-0003KY-6z for linux-um@lists.infradead.org; Thu, 13 Feb 2020 11:12:50 +0000 Subject: Re: [PATCH] virtio: Work around frames incorrectly marked as gso References: <20191209104824.17059-1-anton.ivanov@cambridgegreys.com> <57230228-7030-c65f-a24f-910ca52bbe9e@cambridgegreys.com> <918222d9-816a-be70-f8af-b8dfcb586240@cambridgegreys.com> <20200211053502-mutt-send-email-mst@kernel.org> <9547228b-aa93-f2b6-6fdc-8d33cde3716a@cambridgegreys.com> <20200213045937-mutt-send-email-mst@kernel.org> From: Anton Ivanov Message-ID: <54692f06-f687-8bd3-7a1b-3dac3e79110b@cambridgegreys.com> Date: Thu, 13 Feb 2020 11:12:45 +0000 MIME-Version: 1.0 In-Reply-To: <20200213045937-mutt-send-email-mst@kernel.org> Content-Language: en-US List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-um" Errors-To: linux-um-bounces+geert=linux-m68k.org@lists.infradead.org To: "Michael S. Tsirkin" Cc: netdev@vger.kernel.org, Jason Wang , linux-um@lists.infradead.org, virtualization@lists.linux-foundation.org CgpPbiAxMy8wMi8yMDIwIDEwOjAwLCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gT24gV2Vk LCBGZWIgMTIsIDIwMjAgYXQgMDU6Mzg6MDlQTSArMDAwMCwgQW50b24gSXZhbm92IHdyb3RlOgo+ Pgo+Pgo+PiBPbiAxMS8wMi8yMDIwIDEwOjM3LCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4+ PiBPbiBUdWUsIEZlYiAxMSwgMjAyMCBhdCAwNzo0MjozN0FNICswMDAwLCBBbnRvbiBJdmFub3Yg d3JvdGU6Cj4+Pj4gT24gMTEvMDIvMjAyMCAwMjo1MSwgSmFzb24gV2FuZyB3cm90ZToKPj4+Pj4K Pj4+Pj4gT24gMjAyMC8yLzExIOS4iuWNiDEyOjU1LCBBbnRvbiBJdmFub3Ygd3JvdGU6Cj4+Pj4+ Pgo+Pj4+Pj4KPj4+Pj4+IE9uIDA5LzEyLzIwMTkgMTA6NDgsIGFudG9uLml2YW5vdkBjYW1icmlk Z2VncmV5cy5jb20gd3JvdGU6Cj4+Pj4+Pj4gRnJvbTogQW50b24gSXZhbm92IDxhbnRvbi5pdmFu b3ZAY2FtYnJpZGdlZ3JleXMuY29tPgo+Pj4+Pj4+Cj4+Pj4+Pj4gU29tZSBvZiB0aGUgZnJhbWVz IG1hcmtlZCBhcyBHU08gd2hpY2ggYXJyaXZlIGF0Cj4+Pj4+Pj4gdmlydGlvX25ldF9oZHJfZnJv bV9za2IoKSBoYXZlIG5vIEdTT19UWVBFLCBubwo+Pj4+Pj4+IGZyYWdtZW50cyAoZGF0YV9sZW4g PSAwKSBhbmQgbGVuZ3RoIHNpZ25pZmljYW50bHkgc2hvcnRlcgo+Pj4+Pj4+IHRoYW4gdGhlIE1U VSAoNzUyIGluIG15IGV4cGVyaW1lbnRzKS4KPj4+Pj4+Pgo+Pj4+Pj4+IFRoaXMgaXMgb2JzZXJ2 ZWQgb24gcmF3IHNvY2tldHMgcmVhZGluZyBvZmYgdkV0aCBpbnRlcmZhY2VzCj4+Pj4+Pj4gaW4g YWxsIDQueCBhbmQgNS54IGtlcm5lbHMgSSB0ZXN0ZWQuCj4+Pj4+Pj4KPj4+Pj4+PiBUaGVzZSBm cmFtZXMgYXJlIHJlcG9ydGVkIGFzIGludmFsaWQgd2hpbGUgdGhleSBhcmUgaW4gZmFjdAo+Pj4+ Pj4+IGdzby1sZXNzIGZyYW1lcy4KPj4+Pj4+Pgo+Pj4+Pj4+IFRoaXMgcGF0Y2ggbWFya3MgdGhl IHZuZXQgaGVhZGVyIGFzIG5vLUdTTyBmb3IgdGhlbSBpbnN0ZWFkCj4+Pj4+Pj4gb2YgcmVwb3J0 aW5nIGl0IGFzIGludmFsaWQuCj4+Pj4+Pj4KPj4+Pj4+PiBTaWduZWQtb2ZmLWJ5OiBBbnRvbiBJ dmFub3YgPGFudG9uLml2YW5vdkBjYW1icmlkZ2VncmV5cy5jb20+Cj4+Pj4+Pj4gLS0tCj4+Pj4+ Pj4gICDCoCBpbmNsdWRlL2xpbnV4L3ZpcnRpb19uZXQuaCB8IDggKysrKysrLS0KPj4+Pj4+PiAg IMKgIDEgZmlsZSBjaGFuZ2VkLCA2IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4+Pj4+ Pj4KPj4+Pj4+PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmggYi9pbmNs dWRlL2xpbnV4L3ZpcnRpb19uZXQuaAo+Pj4+Pj4+IGluZGV4IDBkMWZlOTI5N2FjNi4uZDkwZDVj ZmYxYjlhIDEwMDY0NAo+Pj4+Pj4+IC0tLSBhL2luY2x1ZGUvbGludXgvdmlydGlvX25ldC5oCj4+ Pj4+Pj4gKysrIGIvaW5jbHVkZS9saW51eC92aXJ0aW9fbmV0LmgKPj4+Pj4+PiBAQCAtMTEyLDgg KzExMiwxMiBAQCBzdGF0aWMgaW5saW5lIGludAo+Pj4+Pj4+IHZpcnRpb19uZXRfaGRyX2Zyb21f c2tiKGNvbnN0IHN0cnVjdCBza19idWZmICpza2IsCj4+Pj4+Pj4gICDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RDUFY0Owo+Pj4+ Pj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgIGVsc2UgaWYgKHNpbmZvLT5nc29fdHlwZSAmIFNLQl9H U09fVENQVjYpCj4+Pj4+Pj4gICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBoZHItPmdzb190 eXBlID0gVklSVElPX05FVF9IRFJfR1NPX1RDUFY2Owo+Pj4+Pj4+IC3CoMKgwqDCoMKgwqDCoCBl bHNlCj4+Pj4+Pj4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+Pj4+ Pj4gK8KgwqDCoMKgwqDCoMKgIGVsc2Ugewo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKg IGlmIChza2ItPmRhdGFfbGVuID09IDApCj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoCBoZHItPmdzb190eXBlID0gVklSVElPX05FVF9IRFJfR1NPX05PTkU7Cj4+Pj4+Pj4g K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgZWxzZQo+Pj4+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4+Pj4+Pj4gK8KgwqDCoMKgwqDCoMKgIH0KPj4+ Pj4+PiAgIMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoc2luZm8tPmdzb190eXBlICYgU0tCX0dTT19U Q1BfRUNOKQo+Pj4+Pj4+ICAgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaGRyLT5nc29fdHlw ZSB8PSBWSVJUSU9fTkVUX0hEUl9HU09fRUNOOwo+Pj4+Pj4+ICAgwqDCoMKgwqDCoCB9IGVsc2UK Pj4+Pj4+Pgo+Pj4+Pj4KPj4+Pj4+IHBpbmcuCj4+Pj4+Pgo+Pj4+Pgo+Pj4+PiBEbyB5b3UgbWVh biBnc29fc2l6ZSBpcyBzZXQgYnV0IGdzb190eXBlIGlzIG5vdD8gTG9va3MgbGlrZSBhIGJ1Zwo+ Pj4+PiBlbHNld2hlcmUuCj4+Pj4+Cj4+Pj4+IFRoYW5rcwo+Pj4+Pgo+Pj4+Pgo+Pj4+IFllcy4K Pj4+Pgo+Pj4+IEkgY291bGQgbm90IHRyYWNlIGl0IHdoZXJlIGl0IGlzIGNvbWluZyBmcm9tLgo+ Pj4+Cj4+Pj4gSSBzZWUgaXQgd2hlbiBkb2luZyByZWN2bW1zZyBvbiByYXcgc29ja2V0cyBpbiB0 aGUgVU1MIHZlY3RvciBuZXR3b3JrCj4+Pj4gZHJpdmVycy4KPj4+Pgo+Pj4KPj4+IEkgdGhpbmsg d2UgbmVlZCB0byBmaW5kIHRoZSBjdWxwcml0IGFuZCBmaXggaXQgdGhlcmUsIGxvdHMgb2Ygb3Ro ZXIgdGhpbmdzCj4+PiBjYW4gYnJlYWsgb3RoZXJ3aXNlLgo+Pj4gSnVzdCBwcmludGluZyBvdXQg c2tiLT5kZXYtPm5hbWUgc2hvdWxkIGRvIHRoZSB0cmljaywgbm8/Cj4+Cj4+IFRoZSBwcmludGsg aW4gdmlydGlvX25ldF9oZHJfZnJvbV9za2Igc2F5cyBOVUxMLgo+Pgo+PiBUaGF0IGlzIHByb2Jh Ymx5IG5vcm1hbCBmb3IgYSBsb2NhbGx5IG9yaWdpbmF0ZWQgZnJhbWUuCj4+Cj4+IEkgY2Fubm90 IHJlcHJvZHVjZSB0aGlzIHdpdGggbmV0d29yayB0cmFmZmljIGJ5IHRoZSB3YXkgLSBpdCBoYXBw ZW5zIG9ubHkgaWYgdGhlIHRyYWZmaWMgaXMgbG9jYWxseSBvcmlnaW5hdGVkIG9uIHRoZSBob3N0 Lgo+Pgo+PiBBLAo+IAo+IE9LIHNvIGlzIGl0IGNvZGUgaW4gX190Y3BfdHJhbnNtaXRfc2tiIHRo YXQgc2V0cyBnc29fc2l6ZSB0byBub24tbnVsbAo+IHdoZW4gZ3NvX3R5cGUgaXMgMD8KCkl0IGRv ZXMgbG9vayBsaWtlIHRoYXQsIGJ1dCBJIGNhbm5vdCBzZWUgaXQgd2hlbiByZWFkaW5nIGl0IDoo CgoKPiAKPiAKPj4+Cj4+Pgo+Pj4+IC0tIAo+Pj4+IEFudG9uIFIuIEl2YW5vdgo+Pj4+IENhbWJy aWRnZWdyZXlzIExpbWl0ZWQuIFJlZ2lzdGVyZWQgaW4gRW5nbGFuZC4gQ29tcGFueSBOdW1iZXIg MTAyNzM2NjEKPj4+PiBodHRwczovL3d3dy5jYW1icmlkZ2VncmV5cy5jb20vCj4+Pgo+Pj4KPj4+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4+PiBsaW51 eC11bSBtYWlsaW5nIGxpc3QKPj4+IGxpbnV4LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKPj4+IGh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtdW0KPj4+Cj4+ Cj4+IC0tIAo+PiBBbnRvbiBSLiBJdmFub3YKPj4gQ2FtYnJpZGdlZ3JleXMgTGltaXRlZC4gUmVn aXN0ZXJlZCBpbiBFbmdsYW5kLiBDb21wYW55IE51bWJlciAxMDI3MzY2MQo+PiBodHRwczovL3d3 dy5jYW1icmlkZ2VncmV5cy5jb20vCj4gCj4gCgotLSAKQW50b24gUi4gSXZhbm92CkNhbWJyaWRn ZWdyZXlzIExpbWl0ZWQuIFJlZ2lzdGVyZWQgaW4gRW5nbGFuZC4gQ29tcGFueSBOdW1iZXIgMTAy NzM2NjEKaHR0cHM6Ly93d3cuY2FtYnJpZGdlZ3JleXMuY29tLwoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtdW0gbWFpbGluZyBsaXN0CmxpbnV4 LXVtQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC11bQo=