From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mikko Perttunen Subject: Re: [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver Date: Mon, 17 Nov 2014 14:51:24 +0200 Message-ID: <5469EF4C.1050007@kapsi.fi> References: <1411547232-21493-1-git-send-email-l.majewski@samsung.com> <1415898165-27406-1-git-send-email-l.majewski@samsung.com> <1415898165-27406-6-git-send-email-l.majewski@samsung.com> <5465DDC5.6090301@kapsi.fi> <20141117114341.GF25699@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20141117114341.GF25699@ulmo> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Lukasz Majewski , Eduardo Valentin , Zhang Rui , Ezequiel Garcia , Kuninori Morimoto , Linux PM list , Vincenzo Frascino , Bartlomiej Zolnierkiewicz , Lukasz Majewski , Nobuhiro Iwamatsu , Mikko Perttunen , Stephen Warren , Alexandre Courbot , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-tegra@vger.kernel.org On 11/17/2014 01:43 PM, Thierry Reding wrote: > On Fri, Nov 14, 2014 at 12:47:33PM +0200, Mikko Perttunen wrote: >> Tested-by: Mikko Perttunen >> >> One potential issue I can see is that if the cpufreq driver fails to probe >> then you'll never get the thermal driver either. For example, Tegra124 >> currently has no cpufreq driver, so if CONFIG_CPU_THERMAL was enabled, then >> the soctherm driver would never be able to probe. But I don't really have a >> solution for this either. > > It doesn't seem like there's any code whatsoever to deal with cpufreq > within the soctherm driver, so deferring probe based on something we're > not using anyway seems rather useless. > > Thierry > My understanding is that there needs to be no code inside soctherm to handle it, as the cpufreq driver (cpufreq-dt) will register a cooling device that will then be bound to the soctherm sensors using the of-thermal device tree properties. At this moment, however, we don't have that cpufreq driver so this patch is still useless for Tegra. Mikko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751961AbaKQMvm (ORCPT ); Mon, 17 Nov 2014 07:51:42 -0500 Received: from mail.kapsi.fi ([217.30.184.167]:52146 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751483AbaKQMvk (ORCPT ); Mon, 17 Nov 2014 07:51:40 -0500 Message-ID: <5469EF4C.1050007@kapsi.fi> Date: Mon, 17 Nov 2014 14:51:24 +0200 From: Mikko Perttunen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Thierry Reding CC: Lukasz Majewski , Eduardo Valentin , Zhang Rui , Ezequiel Garcia , Kuninori Morimoto , Linux PM list , Vincenzo Frascino , Bartlomiej Zolnierkiewicz , Lukasz Majewski , Nobuhiro Iwamatsu , Mikko Perttunen , Stephen Warren , Alexandre Courbot , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/8] thermal:cpu cooling:tegra: Provide deferred probing for tegra driver References: <1411547232-21493-1-git-send-email-l.majewski@samsung.com> <1415898165-27406-1-git-send-email-l.majewski@samsung.com> <1415898165-27406-6-git-send-email-l.majewski@samsung.com> <5465DDC5.6090301@kapsi.fi> <20141117114341.GF25699@ulmo> In-Reply-To: <20141117114341.GF25699@ulmo> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:708:30:12d0:beee:7bff:fe5b:f272 X-SA-Exim-Mail-From: mikko.perttunen@kapsi.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/17/2014 01:43 PM, Thierry Reding wrote: > On Fri, Nov 14, 2014 at 12:47:33PM +0200, Mikko Perttunen wrote: >> Tested-by: Mikko Perttunen >> >> One potential issue I can see is that if the cpufreq driver fails to probe >> then you'll never get the thermal driver either. For example, Tegra124 >> currently has no cpufreq driver, so if CONFIG_CPU_THERMAL was enabled, then >> the soctherm driver would never be able to probe. But I don't really have a >> solution for this either. > > It doesn't seem like there's any code whatsoever to deal with cpufreq > within the soctherm driver, so deferring probe based on something we're > not using anyway seems rather useless. > > Thierry > My understanding is that there needs to be no code inside soctherm to handle it, as the cpufreq driver (cpufreq-dt) will register a cooling device that will then be bound to the soctherm sensors using the of-thermal device tree properties. At this moment, however, we don't have that cpufreq driver so this patch is still useless for Tegra. Mikko