From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19049C6377D for ; Thu, 22 Jul 2021 05:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8E1A6120C for ; Thu, 22 Jul 2021 05:56:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229931AbhGVFP0 (ORCPT ); Thu, 22 Jul 2021 01:15:26 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:38043 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230123AbhGVFPV (ORCPT ); Thu, 22 Jul 2021 01:15:21 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 547125C00E4; Thu, 22 Jul 2021 01:55:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 22 Jul 2021 01:55:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=Y xsb6Cpj6x3/3PIpedmDhhJBEggqhxSmE1lISmLlGos=; b=NGFtXMzBMlbWynfyW BKFyuPWHSVCd2rhhmAnwhhSjiwo4IwjtXth7qvJJIJkER6rl7TivMSJEbuNVN1DA CV7KmbMLed/I7WBxsiuL/C8GVxG+sWLaFikb9D1ZoDzucClIFsZYhBPwOcgKd5/y vq0QpgpNvYLGvLymMwe761Rke0qwkWP4Gz89PpwR0QW0eYYuHm1dn27+JkaeEtEW 9TrAknnZ/TOyxg1LcycYYaVghvVAVEnRrszOlSZNofw6Ui+3ejgwkUGT4/lBZtY4 L9GEIUYVwYYwma33hB7Dam1fNF+z+tjNhZx0tCwQ91A835ScVPzRwnKpoMh3P1g1 xG2KA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Yxsb6Cpj6x3/3PIpedmDhhJBEggqhxSmE1lISmLlG os=; b=Y62Tl10GLGt5WytsqrshL8z6lniP4Js5yK7W3uzQjVwY/qqmPCn4XoEwa k3YbOvq/9TIEVOzXxYIcpZH3wu8AN9R/cvjiOJXqZ6Npra48s1RsKRajjTEqUGZr 6QB5s48R9SuJeUGcolxtGG9+0hJ+e93MA4jxGRTd8lKbP1yK+Qa4LG4C+vBiFW/Z XgdEpqr43JYAHfqTSeG+ITM1/g3ZCxD3wxNaJ+/+SIZq/Dt+JEicODA28a9/vLDG 0p54UF0sbFnTPrqvaLAmKY5DjXtyZVzrNzX9IO/7UCTlsYFszcg+HlKNQygmT/G8 6iD3L1efn3m7rI1lLsIIZen343NMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeehgddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepvddttdejieduudfgffevteekffegffeguddtgfefkeduvedukeff hedtfeevuedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 01:55:54 -0400 (EDT) To: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, Rob Herring , Frank Rowand Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com References: <20210721140424.725744-1-maxime@cerno.tech> <20210721140424.725744-53-maxime@cerno.tech> From: Samuel Holland Subject: Re: [PATCH 52/54] arm64: dts: allwinner: Remove regulator-ramp-delay Message-ID: <5469a059-dad1-38d2-9ea4-f1b5fa9ac616@sholland.org> Date: Thu, 22 Jul 2021 00:55:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210721140424.725744-53-maxime@cerno.tech> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 7/21/21 9:04 AM, Maxime Ripard wrote: > The regulator-ramp-delay property isn't documented in the binding for > the AXP806, and it's ignored by the driver. Remove those properties. This is a generic regulator property, parsed by of_get_regulation_constraints, which is called by regulator_of_get_init_data in the regulator core. And it appears in bindings/regulator/regulator.yaml. I believe the binding needs to be fixed, not the device trees. Regards, Samuel > Signed-off-by: Maxime Ripard > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 2 -- > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts | 2 -- > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > index 6249e9e02928..a02644eebbe4 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > @@ -256,7 +256,6 @@ reg_dcdca: dcdca { > regulator-always-on; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1160000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-cpu"; > }; > > @@ -264,7 +263,6 @@ reg_dcdcc: dcdcc { > regulator-enable-ramp-delay = <32000>; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1080000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-gpu"; > }; > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > index c45d7b7fb39a..69c0293aeb16 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > @@ -262,7 +262,6 @@ reg_dcdca: dcdca { > regulator-always-on; > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <1160000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-cpu"; > }; > > @@ -270,7 +269,6 @@ reg_dcdcc: dcdcc { > regulator-enable-ramp-delay = <32000>; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1080000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-gpu"; > }; > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > index 1ffd68f43f87..6a1ee4232675 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > @@ -245,7 +245,6 @@ reg_dcdca: dcdca { > regulator-always-on; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1160000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-cpu"; > }; > > @@ -253,7 +252,6 @@ reg_dcdcc: dcdcc { > regulator-enable-ramp-delay = <32000>; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1080000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-gpu"; > }; > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62172C6377D for ; Thu, 22 Jul 2021 05:58:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 157F06120C for ; Thu, 22 Jul 2021 05:58:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 157F06120C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sholland.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:Subject:From:References:Cc:To:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=icP+xc/87VDjfGGcEdz/lUi+ij8HKUr8El2MBSL0pus=; b=E+DUSu/HgkpDVpsciyjxYKNyfd Dz/o2D0IOS0pDWB0vUrlI4g/GIO3JWTxImn9L5X4J/rJK6tp7O6GW3QiyelTIJ+g6UqNARKBIL8jB RfTinZZ4ihMb5h8C2UeM0H6CTkp85ZIvHbEveRfWnAxLMf+GdW3qg0wZnnuBuRJLq9L+gXRuNiO04 I5rbVACTuqRbMlboG7pBbe8un4koCEse3jZZo7Thsew1QcOwTYysETbpt2oEjY2Fu3+kbm0dVDwJc auMopYLkVhapejS17aBgT9cWsErt64s/eTUoSSXNflTBzzp0FX//0tCYBGUnZMb27fmA+v3l19mvi sQG4DEsQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Rge-000HzL-WF; Thu, 22 Jul 2021 05:56:01 +0000 Received: from out3-smtp.messagingengine.com ([66.111.4.27]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6Rga-000Hz0-ME for linux-arm-kernel@lists.infradead.org; Thu, 22 Jul 2021 05:55:59 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 547125C00E4; Thu, 22 Jul 2021 01:55:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Thu, 22 Jul 2021 01:55:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= to:cc:references:from:subject:message-id:date:mime-version :in-reply-to:content-type:content-transfer-encoding; s=fm3; bh=Y xsb6Cpj6x3/3PIpedmDhhJBEggqhxSmE1lISmLlGos=; b=NGFtXMzBMlbWynfyW BKFyuPWHSVCd2rhhmAnwhhSjiwo4IwjtXth7qvJJIJkER6rl7TivMSJEbuNVN1DA CV7KmbMLed/I7WBxsiuL/C8GVxG+sWLaFikb9D1ZoDzucClIFsZYhBPwOcgKd5/y vq0QpgpNvYLGvLymMwe761Rke0qwkWP4Gz89PpwR0QW0eYYuHm1dn27+JkaeEtEW 9TrAknnZ/TOyxg1LcycYYaVghvVAVEnRrszOlSZNofw6Ui+3ejgwkUGT4/lBZtY4 L9GEIUYVwYYwma33hB7Dam1fNF+z+tjNhZx0tCwQ91A835ScVPzRwnKpoMh3P1g1 xG2KA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Yxsb6Cpj6x3/3PIpedmDhhJBEggqhxSmE1lISmLlG os=; b=Y62Tl10GLGt5WytsqrshL8z6lniP4Js5yK7W3uzQjVwY/qqmPCn4XoEwa k3YbOvq/9TIEVOzXxYIcpZH3wu8AN9R/cvjiOJXqZ6Npra48s1RsKRajjTEqUGZr 6QB5s48R9SuJeUGcolxtGG9+0hJ+e93MA4jxGRTd8lKbP1yK+Qa4LG4C+vBiFW/Z XgdEpqr43JYAHfqTSeG+ITM1/g3ZCxD3wxNaJ+/+SIZq/Dt+JEicODA28a9/vLDG 0p54UF0sbFnTPrqvaLAmKY5DjXtyZVzrNzX9IO/7UCTlsYFszcg+HlKNQygmT/G8 6iD3L1efn3m7rI1lLsIIZen343NMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeehgddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepvfhfhffukffffgggjggtgfesthekredttdefjeenucfhrhhomhepufgrmhhu vghlucfjohhllhgrnhguuceoshgrmhhuvghlsehshhholhhlrghnugdrohhrgheqnecugg ftrfgrthhtvghrnhepvddttdejieduudfgffevteekffegffeguddtgfefkeduvedukeff hedtfeevuedvnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepshgrmhhuvghlsehshhholhhlrghnugdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 01:55:54 -0400 (EDT) To: Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, Rob Herring , Frank Rowand Cc: linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com References: <20210721140424.725744-1-maxime@cerno.tech> <20210721140424.725744-53-maxime@cerno.tech> From: Samuel Holland Subject: Re: [PATCH 52/54] arm64: dts: allwinner: Remove regulator-ramp-delay Message-ID: <5469a059-dad1-38d2-9ea4-f1b5fa9ac616@sholland.org> Date: Thu, 22 Jul 2021 00:55:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux ppc64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210721140424.725744-53-maxime@cerno.tech> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210721_225558_100317_916DBA5C X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/21/21 9:04 AM, Maxime Ripard wrote: > The regulator-ramp-delay property isn't documented in the binding for > the AXP806, and it's ignored by the driver. Remove those properties. This is a generic regulator property, parsed by of_get_regulation_constraints, which is called by regulator_of_get_init_data in the regulator core. And it appears in bindings/regulator/regulator.yaml. I believe the binding needs to be fixed, not the device trees. Regards, Samuel > Signed-off-by: Maxime Ripard > --- > arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 2 -- > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts | 2 -- > arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts | 2 -- > 3 files changed, 6 deletions(-) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > index 6249e9e02928..a02644eebbe4 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts > @@ -256,7 +256,6 @@ reg_dcdca: dcdca { > regulator-always-on; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1160000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-cpu"; > }; > > @@ -264,7 +263,6 @@ reg_dcdcc: dcdcc { > regulator-enable-ramp-delay = <32000>; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1080000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-gpu"; > }; > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > index c45d7b7fb39a..69c0293aeb16 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts > @@ -262,7 +262,6 @@ reg_dcdca: dcdca { > regulator-always-on; > regulator-min-microvolt = <800000>; > regulator-max-microvolt = <1160000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-cpu"; > }; > > @@ -270,7 +269,6 @@ reg_dcdcc: dcdcc { > regulator-enable-ramp-delay = <32000>; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1080000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-gpu"; > }; > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > index 1ffd68f43f87..6a1ee4232675 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-pine-h64.dts > @@ -245,7 +245,6 @@ reg_dcdca: dcdca { > regulator-always-on; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1160000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-cpu"; > }; > > @@ -253,7 +252,6 @@ reg_dcdcc: dcdcc { > regulator-enable-ramp-delay = <32000>; > regulator-min-microvolt = <810000>; > regulator-max-microvolt = <1080000>; > - regulator-ramp-delay = <2500>; > regulator-name = "vdd-gpu"; > }; > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel