From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754180AbaKRLVW (ORCPT ); Tue, 18 Nov 2014 06:21:22 -0500 Received: from mout.web.de ([212.227.17.12]:51386 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752917AbaKRLVT (ORCPT ); Tue, 18 Nov 2014 06:21:19 -0500 Message-ID: <546B2B8A.4090809@users.sourceforge.net> Date: Tue, 18 Nov 2014 12:20:42 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Alexander Viro , linux-fsdevel@vger.kernel.org CC: LKML , kernel-janitors@vger.kernel.org, Coccinelle Subject: [PATCH 1/1] fs-namespace: Deletion of unnecessary checks before the function call "mntput" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jQHzjxUvS6y6U68600eAtLWCbW2p11PgSVqVTfF/nT6um/S0ZDB P+Rui20zQjUXSKfJw3HtX4SvLFoA/XXqlnhWUGJBfJQGxov1M41mv/qhUPhquH0glo/LZK2 fZ6x9YeFATHSr/OOijmuhy2Ze6s4umqmARd0fL0icae7C4UYrqdskYUV5+lRtTe6Iurae3H i5GX1INKn8s4DC3aTJOzQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Tue, 18 Nov 2014 12:10:43 +0100 The mntput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/namespace.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 550dbff..3b3710e 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2615,10 +2615,8 @@ struct mnt_namespace *copy_mnt_ns(unsigned long flags, struct mnt_namespace *ns, } namespace_unlock(); - if (rootmnt) - mntput(rootmnt); - if (pwdmnt) - mntput(pwdmnt); + mntput(rootmnt); + mntput(pwdmnt); return new_ns; } -- 2.1.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: [PATCH 1/1] fs-namespace: Deletion of unnecessary checks before the function call "mntput" Date: Tue, 18 Nov 2014 12:20:42 +0100 Message-ID: <546B2B8A.4090809@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: LKML , kernel-janitors@vger.kernel.org, Coccinelle To: Alexander Viro , linux-fsdevel@vger.kernel.org Return-path: In-Reply-To: <5317A59D.4@users.sourceforge.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org From: Markus Elfring Date: Tue, 18 Nov 2014 12:10:43 +0100 The mntput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/namespace.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 550dbff..3b3710e 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2615,10 +2615,8 @@ struct mnt_namespace *copy_mnt_ns(unsigned long flags, struct mnt_namespace *ns, } namespace_unlock(); - if (rootmnt) - mntput(rootmnt); - if (pwdmnt) - mntput(pwdmnt); + mntput(rootmnt); + mntput(pwdmnt); return new_ns; } -- 2.1.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 18 Nov 2014 11:20:42 +0000 Subject: [PATCH 1/1] fs-namespace: Deletion of unnecessary checks before the function call "mntput" Message-Id: <546B2B8A.4090809@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: cocci@systeme.lip6.fr From: Markus Elfring Date: Tue, 18 Nov 2014 12:10:43 +0100 The mntput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/namespace.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 550dbff..3b3710e 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2615,10 +2615,8 @@ struct mnt_namespace *copy_mnt_ns(unsigned long flags, struct mnt_namespace *ns, } namespace_unlock(); - if (rootmnt) - mntput(rootmnt); - if (pwdmnt) - mntput(pwdmnt); + mntput(rootmnt); + mntput(pwdmnt); return new_ns; } -- 2.1.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Tue, 18 Nov 2014 12:20:42 +0100 Subject: [Cocci] [PATCH 1/1] fs-namespace: Deletion of unnecessary checks before the function call "mntput" In-Reply-To: <5317A59D.4@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> Message-ID: <546B2B8A.4090809@users.sourceforge.net> To: cocci@systeme.lip6.fr List-Id: cocci@systeme.lip6.fr From: Markus Elfring Date: Tue, 18 Nov 2014 12:10:43 +0100 The mntput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- fs/namespace.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/fs/namespace.c b/fs/namespace.c index 550dbff..3b3710e 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -2615,10 +2615,8 @@ struct mnt_namespace *copy_mnt_ns(unsigned long flags, struct mnt_namespace *ns, } namespace_unlock(); - if (rootmnt) - mntput(rootmnt); - if (pwdmnt) - mntput(pwdmnt); + mntput(rootmnt); + mntput(pwdmnt); return new_ns; } -- 2.1.3