From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756150AbaKSRA4 (ORCPT ); Wed, 19 Nov 2014 12:00:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57223 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755804AbaKSRAy (ORCPT ); Wed, 19 Nov 2014 12:00:54 -0500 Message-ID: <546CCC9E.7090905@redhat.com> Date: Wed, 19 Nov 2014 18:00:14 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: John Fastabend CC: SF Markus Elfring , "David S. Miller" , Jamal Hadi Salim , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Coccinelle Subject: Re: [PATCH 1/1] net: sched: Deletion of an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAB93.4010406@users.sourceforge.net> <546CC9B3.5060405@gmail.com> In-Reply-To: <546CC9B3.5060405@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/19/2014 05:47 PM, John Fastabend wrote: > On 11/18/2014 12:26 PM, SF Markus Elfring wrote: >> From: Markus Elfring ... >> if (fp_old) >> bpf_prog_destroy(fp_old); >> - if (bpf_old) >> - kfree(bpf_old); >> + kfree(bpf_old); >> >> return 0; >> > > Maybe I need some coffee but I can't figure out what this > patch is against... > > # grep bpf_old ./net/sched/cls_bpf.c > # Coffee is always good. :) Yeah, you actually removed this in commit 1f947bf151e90ec ("net: sched: rcu'ify cls_bpf"), so looks like Markus's tree is not up to date ... From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: [PATCH 1/1] net: sched: Deletion of an unnecessary check before the function call "kfree" Date: Wed, 19 Nov 2014 18:00:14 +0100 Message-ID: <546CCC9E.7090905@redhat.com> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <546BAB93.4010406@users.sourceforge.net> <546CC9B3.5060405@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: SF Markus Elfring , "David S. Miller" , Jamal Hadi Salim , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Coccinelle To: John Fastabend Return-path: In-Reply-To: <546CC9B3.5060405@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 11/19/2014 05:47 PM, John Fastabend wrote: > On 11/18/2014 12:26 PM, SF Markus Elfring wrote: >> From: Markus Elfring ... >> if (fp_old) >> bpf_prog_destroy(fp_old); >> - if (bpf_old) >> - kfree(bpf_old); >> + kfree(bpf_old); >> >> return 0; >> > > Maybe I need some coffee but I can't figure out what this > patch is against... > > # grep bpf_old ./net/sched/cls_bpf.c > # Coffee is always good. :) Yeah, you actually removed this in commit 1f947bf151e90ec ("net: sched: rcu'ify cls_bpf"), so looks like Markus's tree is not up to date ... From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Date: Wed, 19 Nov 2014 17:00:14 +0000 Subject: Re: [PATCH 1/1] net: sched: Deletion of an unnecessary check before the function call "kfree" Message-Id: <546CCC9E.7090905@redhat.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAB93.4010406@users.sourceforge.net> <546CC9B3.5060405@gmail.com> In-Reply-To: <546CC9B3.5060405@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: John Fastabend Cc: SF Markus Elfring , "David S. Miller" , Jamal Hadi Salim , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Coccinelle On 11/19/2014 05:47 PM, John Fastabend wrote: > On 11/18/2014 12:26 PM, SF Markus Elfring wrote: >> From: Markus Elfring ... >> if (fp_old) >> bpf_prog_destroy(fp_old); >> - if (bpf_old) >> - kfree(bpf_old); >> + kfree(bpf_old); >> >> return 0; >> > > Maybe I need some coffee but I can't figure out what this > patch is against... > > # grep bpf_old ./net/sched/cls_bpf.c > # Coffee is always good. :) Yeah, you actually removed this in commit 1f947bf151e90ec ("net: sched: rcu'ify cls_bpf"), so looks like Markus's tree is not up to date ...