From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757365AbaKTJXL (ORCPT ); Thu, 20 Nov 2014 04:23:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54376 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756137AbaKTJXH (ORCPT ); Thu, 20 Nov 2014 04:23:07 -0500 Message-ID: <546DB2E8.10809@redhat.com> Date: Thu, 20 Nov 2014 10:22:48 +0100 From: Daniel Borkmann User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Julia Lawall CC: SF Markus Elfring , John Fastabend , "David S. Miller" , Jamal Hadi Salim , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: net: sched: Deletion of an unnecessary check before the function call "kfree" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAB93.4010406@users.sourceforge.net> <546CC9B3.5060405@gmail.com> <546CE650.6080205@users.sourceforge.net> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/20/2014 09:47 AM, Julia Lawall wrote: > On Wed, 19 Nov 2014, SF Markus Elfring wrote: > >>> Marcus, what tree are you looking at? >> >> I dared to base this update suggestion on the source files >> for Linux 3.17.3. Are newer software developments relevant here? > > You should always use linux-next. You should update it every day. Well, if you send in cleanups to netdev, you should always target the net-next tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Subject: Re: net: sched: Deletion of an unnecessary check before the function call "kfree" Date: Thu, 20 Nov 2014 10:22:48 +0100 Message-ID: <546DB2E8.10809@redhat.com> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <546BAB93.4010406@users.sourceforge.net> <546CC9B3.5060405@gmail.com> <546CE650.6080205@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: SF Markus Elfring , John Fastabend , "David S. Miller" , Jamal Hadi Salim , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org To: Julia Lawall Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 11/20/2014 09:47 AM, Julia Lawall wrote: > On Wed, 19 Nov 2014, SF Markus Elfring wrote: > >>> Marcus, what tree are you looking at? >> >> I dared to base this update suggestion on the source files >> for Linux 3.17.3. Are newer software developments relevant here? > > You should always use linux-next. You should update it every day. Well, if you send in cleanups to netdev, you should always target the net-next tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Borkmann Date: Thu, 20 Nov 2014 09:22:48 +0000 Subject: Re: net: sched: Deletion of an unnecessary check before the function call "kfree" Message-Id: <546DB2E8.10809@redhat.com> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546BAB93.4010406@users.sourceforge.net> <546CC9B3.5060405@gmail.com> <546CE650.6080205@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: SF Markus Elfring , John Fastabend , "David S. Miller" , Jamal Hadi Salim , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org On 11/20/2014 09:47 AM, Julia Lawall wrote: > On Wed, 19 Nov 2014, SF Markus Elfring wrote: > >>> Marcus, what tree are you looking at? >> >> I dared to base this update suggestion on the source files >> for Linux 3.17.3. Are newer software developments relevant here? > > You should always use linux-next. You should update it every day. Well, if you send in cleanups to netdev, you should always target the net-next tree: git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git