From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54172)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Xrl24-0007G1-IA
	for qemu-devel@nongnu.org; Fri, 21 Nov 2014 05:01:49 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Xrl1t-0001JG-Dd
	for qemu-devel@nongnu.org; Fri, 21 Nov 2014 05:01:40 -0500
Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:55912)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <borntraeger@de.ibm.com>) id 1Xrl1t-0001Ir-3g
	for qemu-devel@nongnu.org; Fri, 21 Nov 2014 05:01:29 -0500
Received: from /spool/local
	by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <borntraeger@de.ibm.com>;
	Fri, 21 Nov 2014 10:01:27 -0000
Received: from b06cxnps3074.portsmouth.uk.ibm.com
	(d06relay09.portsmouth.uk.ibm.com [9.149.109.194])
	by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 484C817D8056
	for <qemu-devel@nongnu.org>; Fri, 21 Nov 2014 10:01:37 +0000 (GMT)
Received: from d06av06.portsmouth.uk.ibm.com (d06av06.portsmouth.uk.ibm.com
	[9.149.37.217])
	by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with
	ESMTP id sALA1NkF12517868
	for <qemu-devel@nongnu.org>; Fri, 21 Nov 2014 10:01:23 GMT
Received: from d06av06.portsmouth.uk.ibm.com (localhost [127.0.0.1])
	by d06av06.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with
	ESMTP id sAL4wV5d024017
	for <qemu-devel@nongnu.org>; Thu, 20 Nov 2014 23:58:32 -0500
Message-ID: <546F0D72.3020307@de.ibm.com>
Date: Fri, 21 Nov 2014 11:01:22 +0100
From: Christian Borntraeger <borntraeger@de.ibm.com>
MIME-Version: 1.0
References: <1416392276-10408-1-git-send-email-tumanova@linux.vnet.ibm.com>
	<1416392276-10408-2-git-send-email-tumanova@linux.vnet.ibm.com>
In-Reply-To: <1416392276-10408-2-git-send-email-tumanova@linux.vnet.ibm.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 1/6] geometry: add bdrv functions for
 geometry and blocksize
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ekaterina Tumanova <tumanova@linux.vnet.ibm.com>, Public KVM Mailing List <qemu-devel@nongnu.org>
Cc: kwolf@redhat.com, armbru@redhat.com, mihajlov@linux.vnet.ibm.com, dahi@linux.vnet.ibm.com, stefanha@redhat.com, cornelia.huck@de.ibm.com, pbonzini@redhat.com

Am 19.11.2014 um 11:17 schrieb Ekaterina Tumanova:
> Add driver functions for geometry and blocksize detection
> 
[...]
>  /*
>   * Create a uniquely-named empty temporary file.
>   * Return 0 upon success, otherwise a negative errno value.
> diff --git a/include/block/block.h b/include/block/block.h
> index 5450610..3287dbc 100644
> --- a/include/block/block.h
> +++ b/include/block/block.h
> @@ -60,6 +60,24 @@ typedef enum {
>      BDRV_REQ_MAY_UNMAP    = 0x4,
>  } BdrvRequestFlags;
> 

question for Kevin/Stefan/Marcus,
is belows rc type of return code ok for you (see patch 5 for its usage)?


> +struct ProbeBlockSize {
> +    int rc;
> +    struct BlockSize {
> +        uint16_t phys;
> +        uint16_t log;
> +    } size;
> +};

Kate, can you make this a typedef so that you dont need to drag along "struct"?


> +
> +struct ProbeGeometry {
> +    int rc;
> +    struct HDGeometry {
> +        uint32_t heads;
> +        uint32_t sectors;
> +        uint32_t cylinders;
> +        uint32_t start;
> +    } geo;
> +};

dito


Otherwise looks sane.