From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754778AbaKUKlF (ORCPT ); Fri, 21 Nov 2014 05:41:05 -0500 Received: from mout.web.de ([212.227.15.4]:60749 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbaKUKlE (ORCPT ); Fri, 21 Nov 2014 05:41:04 -0500 Message-ID: <546F16A5.8030405@users.sourceforge.net> Date: Fri, 21 Nov 2014 11:40:37 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andreas Noever CC: LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH 1/1] thunderbolt: Deletion of unnecessary checks before the function call "ring_free" References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:7X/PizdUj20Zd/AL66ektf3dAlVBF+BH9EgcpFh9swhJEEsOuzC aMEBoecEQgWmtlbJDAj11kvHDwKyqRU3RQuTdnlowUckP9arymhqWcMAyK8qz35rtNsHQbY TiFJQ+lWYFeGSV5VaoZ3wNmNrphWQeRcZtf9oc/YdAyTcuxLYnHVmRdYu/TBwf0eR9ye8hA dN663bGzRMZzgcg8CHyNg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 21 Nov 2014 11:30:18 +0100 The ring_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/thunderbolt/ctl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c index 799634b..55b9bdf 100644 --- a/drivers/thunderbolt/ctl.c +++ b/drivers/thunderbolt/ctl.c @@ -520,10 +520,8 @@ err: void tb_ctl_free(struct tb_ctl *ctl) { int i; - if (ctl->rx) - ring_free(ctl->rx); - if (ctl->tx) - ring_free(ctl->tx); + ring_free(ctl->rx); + ring_free(ctl->tx); /* free RX packets */ for (i = 0; i < TB_CTL_RX_PKG_COUNT; i++) -- 2.1.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 21 Nov 2014 10:40:37 +0000 Subject: [PATCH 1/1] thunderbolt: Deletion of unnecessary checks before the function call "ring_free" Message-Id: <546F16A5.8030405@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> In-Reply-To: <5317A59D.4@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Andreas Noever Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring Date: Fri, 21 Nov 2014 11:30:18 +0100 The ring_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/thunderbolt/ctl.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/thunderbolt/ctl.c b/drivers/thunderbolt/ctl.c index 799634b..55b9bdf 100644 --- a/drivers/thunderbolt/ctl.c +++ b/drivers/thunderbolt/ctl.c @@ -520,10 +520,8 @@ err: void tb_ctl_free(struct tb_ctl *ctl) { int i; - if (ctl->rx) - ring_free(ctl->rx); - if (ctl->tx) - ring_free(ctl->tx); + ring_free(ctl->rx); + ring_free(ctl->tx); /* free RX packets */ for (i = 0; i < TB_CTL_RX_PKG_COUNT; i++) -- 2.1.3