From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758346AbaKUN0P (ORCPT ); Fri, 21 Nov 2014 08:26:15 -0500 Received: from mout.web.de ([212.227.15.14]:51217 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755232AbaKUN0O (ORCPT ); Fri, 21 Nov 2014 08:26:14 -0500 Message-ID: <546F3D59.2060504@users.sourceforge.net> Date: Fri, 21 Nov 2014 14:25:45 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Julia Lawall CC: Eduardo Valentin , Kukjin Kim , Zhang Rui , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org Subject: Re: thermal: Exynos: Deletion of unnecessary checks before two function calls References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F1017.5080403@users.sourceforge.net> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:jrs3As7tj5MTa+SI1tTtrol7MaJUMZVlC9YU0tWZ7lmIn0enkh6 2u3h2WqBpWUyGHHnR3yteIOkKdszVcM68PL+T+gzpODPBJCf055GL+SsA7ZORuBXANFkzoK U30KNb7MiA0CyOmpp6mbwJ9AodISaEXbqgrEMuiFkgb4BZJXqAKgS7TehhwLsqKnGK1OUq0 5mVxiWM3fKEVOakq0jd1A== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> for (i = 0; i < th_zone->cool_dev_size; i++) { >> - if (th_zone->cool_dev[i]) >> - cpufreq_cooling_unregister(th_zone->cool_dev[i]); >> + cpufreq_cooling_unregister(th_zone->cool_dev[i]); >> } > > Now you have unnecessary {} How are the chances that your source code transformation tool can also consider the deletion of curly brackets in such an use case? Can any more pretty-printing rules be integrated from a specific coding style configuration? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 21 Nov 2014 13:25:45 +0000 Subject: Re: thermal: Exynos: Deletion of unnecessary checks before two function calls Message-Id: <546F3D59.2060504@users.sourceforge.net> List-Id: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F1017.5080403@users.sourceforge.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org >> for (i = 0; i < th_zone->cool_dev_size; i++) { >> - if (th_zone->cool_dev[i]) >> - cpufreq_cooling_unregister(th_zone->cool_dev[i]); >> + cpufreq_cooling_unregister(th_zone->cool_dev[i]); >> } > > Now you have unnecessary {} How are the chances that your source code transformation tool can also consider the deletion of curly brackets in such an use case? Can any more pretty-printing rules be integrated from a specific coding style configuration? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: thermal: Exynos: Deletion of unnecessary checks before two function calls Date: Fri, 21 Nov 2014 14:25:45 +0100 Message-ID: <546F3D59.2060504@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <546F1017.5080403@users.sourceforge.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-samsung-soc-owner@vger.kernel.org To: Julia Lawall Cc: Eduardo Valentin , Kukjin Kim , Zhang Rui , linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org List-Id: linux-pm@vger.kernel.org >> for (i = 0; i < th_zone->cool_dev_size; i++) { >> - if (th_zone->cool_dev[i]) >> - cpufreq_cooling_unregister(th_zone->cool_dev[i]); >> + cpufreq_cooling_unregister(th_zone->cool_dev[i]); >> } > > Now you have unnecessary {} How are the chances that your source code transformation tool can also consider the deletion of curly brackets in such an use case? Can any more pretty-printing rules be integrated from a specific coding style configuration? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Fri, 21 Nov 2014 14:25:45 +0100 Subject: thermal: Exynos: Deletion of unnecessary checks before two function calls In-Reply-To: References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <546F1017.5080403@users.sourceforge.net> Message-ID: <546F3D59.2060504@users.sourceforge.net> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org >> for (i = 0; i < th_zone->cool_dev_size; i++) { >> - if (th_zone->cool_dev[i]) >> - cpufreq_cooling_unregister(th_zone->cool_dev[i]); >> + cpufreq_cooling_unregister(th_zone->cool_dev[i]); >> } > > Now you have unnecessary {} How are the chances that your source code transformation tool can also consider the deletion of curly brackets in such an use case? Can any more pretty-printing rules be integrated from a specific coding style configuration? Regards, Markus