From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
To: Eric Dumazet <edumazet@google.com>, David Miller <davem@davemloft.net>
Cc: netdev <netdev@vger.kernel.org>,
Mingfangsen <mingfangsen@huawei.com>,
"Zhoukang (A)" <zhoukang7@huawei.com>,
"wangxiaogang (F)" <wangxiaogang3@huawei.com>
Subject: [PATCH net] inet_connection_sock: remove unused parameter of reqsk_queue_unlink func
Date: Wed, 5 Jun 2019 18:49:49 +0800 [thread overview]
Message-ID: <546c6d2f-39ca-521d-7009-d80df735bd9e@huawei.com> (raw)
In-Reply-To: <40f32663-f100-169c-4d1b-79d64d68a5f9@huawei.com>
small cleanup: "struct request_sock_queue *queue" parameter of reqsk_queue_unlink
func is never used in the func, so we can remove it.
Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
---
net/ipv4/inet_connection_sock.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/net/ipv4/inet_connection_sock.c b/net/ipv4/inet_connection_sock.c
index 6ea523d71947..632855a8abb3 100644
--- a/net/ipv4/inet_connection_sock.c
+++ b/net/ipv4/inet_connection_sock.c
@@ -653,8 +653,7 @@ int inet_rtx_syn_ack(const struct sock *parent, struct request_sock *req)
EXPORT_SYMBOL(inet_rtx_syn_ack);
/* return true if req was found in the ehash table */
-static bool reqsk_queue_unlink(struct request_sock_queue *queue,
- struct request_sock *req)
+static bool reqsk_queue_unlink(struct request_sock *req)
{
struct inet_hashinfo *hashinfo = req_to_sk(req)->sk_prot->h.hashinfo;
bool found = false;
@@ -673,7 +672,7 @@ static bool reqsk_queue_unlink(struct request_sock_queue *queue,
void inet_csk_reqsk_queue_drop(struct sock *sk, struct request_sock *req)
{
- if (reqsk_queue_unlink(&inet_csk(sk)->icsk_accept_queue, req)) {
+ if (reqsk_queue_unlink(req)) {
reqsk_queue_removed(&inet_csk(sk)->icsk_accept_queue, req);
reqsk_put(req);
}
--
next prev parent reply other threads:[~2019-06-05 10:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 14:55 [PATCH net] tcp: avoid creating multiple req socks with the same tuples Mao Wenan
2019-06-04 15:24 ` Eric Dumazet
2019-06-05 2:06 ` maowenan
2019-06-05 3:16 ` Eric Dumazet
2019-06-05 8:52 ` Zhiqiang Liu
2019-06-05 10:49 ` Zhiqiang Liu [this message]
2019-06-05 14:10 ` [PATCH net] inet_connection_sock: remove unused parameter of reqsk_queue_unlink func Eric Dumazet
2019-06-06 1:49 ` David Miller
2019-06-06 2:06 ` Zhiqiang Liu
2019-06-06 2:19 ` David Miller
2019-06-06 2:29 ` Zhiqiang Liu
2019-06-05 14:18 ` [PATCH net] tcp: avoid creating multiple req socks with the same tuples Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546c6d2f-39ca-521d-7009-d80df735bd9e@huawei.com \
--to=liuzhiqiang26@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=mingfangsen@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=wangxiaogang3@huawei.com \
--cc=zhoukang7@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.