From mboxrd@z Thu Jan  1 00:00:00 1970
From: M. Braun <michael-dev@fami-braun.de>
Date: Mon, 24 Nov 2014 10:10:28 +0100
Subject: [ath9k-devel] queue priority mapping
In-Reply-To: <CAFfN3gX-Jtk2hh8tpBgvXkDgxbEjucOPevhJdYYXzt-0m-q9Dg@mail.gmail.com>
References: <CAFfN3gX-Jtk2hh8tpBgvXkDgxbEjucOPevhJdYYXzt-0m-q9Dg@mail.gmail.com>
Message-ID: <5472F604.3020404@fami-braun.de>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

Hi,

Am 20.11.2014 um 19:00 schrieb Hubert Feurstein:
> in ath9k_init_queues are the AC levels mapped to the hardware-queues by
> this loop below. But doesn't this map the priorities in the wrong
> direction? The hardware queue 0 has the lowest priority, but is mapped to
> IEEE80211_AC_VO. And the hardware queue 3 (with higher priority) is mapped
> to IEEE80211_AC_BK. Shouldn't that be the other way around (as changed
> below) ?

I don't know about the hw priority stuff, but the change you propose
does not change the resulting data structure at all.
You'd likely need to change mac80211_qnum to be IEEE80211_NUM_ACS-1-i
(and maybe others) to change the mapping.

Regards,
 M. Braun

> 
> @@ -323,11 +323,12 @@ static int ath9k_init_queues(struct ath_softc *sc)
>   sc->beacon.cabq = ath_txq_setup(sc, ATH9K_TX_QUEUE_CAB, 0);
>   ath_cabq_update(sc);
> 
>   sc->tx.uapsdq = ath_txq_setup(sc, ATH9K_TX_QUEUE_UAPSD, 0);
> 
> - for (i = 0; i < IEEE80211_NUM_ACS; i++) {
> + for (i = IEEE80211_NUM_ACS - 1; i >= 0; i--) {
>   sc->tx.txq_map[i] = ath_txq_setup(sc, ATH9K_TX_QUEUE_DATA, i);
>   sc->tx.txq_map[i]->mac80211_qnum = i;
>   sc->tx.txq_max_pending[i] = ATH_MAX_QDEPTH;
>   }
>   return 0;
> 
> Best regards
> Hubert
> 
> 
> 
> _______________________________________________
> ath9k-devel mailing list
> ath9k-devel at lists.ath9k.org
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
>