From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754745AbaKXSFs (ORCPT ); Mon, 24 Nov 2014 13:05:48 -0500 Received: from mout.web.de ([212.227.17.12]:58638 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754508AbaKXSFq (ORCPT ); Mon, 24 Nov 2014 13:05:46 -0500 Message-ID: <5473736F.8070705@users.sourceforge.net> Date: Mon, 24 Nov 2014 19:05:35 +0100 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Lee Jones CC: Bryan Wu , Jean-Christophe Plagniol-Villard , Jingoo Han , Tomi Valkeinen , linux-fbdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Subject: [PATCH v2] backlight: lp8788: Deletion of a check before backlight_device_unregister() References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54720DEB.4060109@users.sourceforge.net> <20141124101006.GD4241@x1> In-Reply-To: <20141124101006.GD4241@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:29I3W/HReuiL/fJocNqrXedRkK/OAfJkbLjEaE83W9ezZPnmjFb gT1AW1ERRCCIaX5517AgzBDwpTrxJ2loE6D1950QzJld6FJm1U0EXhzof8+qRFAygpdBj1G jjthzM+YeUVeNOMUkQ/1yJvoLs9Eza4CEsF6992KMsKdTCiFpkjg9QGCaoilS5Po7gM+CdS LiyF0Cegb9Wd+zAtH1/PQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/backlight/lp8788_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c index d6c4f6a..24a055c 100644 --- a/drivers/video/backlight/lp8788_bl.c +++ b/drivers/video/backlight/lp8788_bl.c @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl) { struct backlight_device *bl_dev = bl->bl_dev; - if (bl_dev) - backlight_device_unregister(bl_dev); + backlight_device_unregister(bl_dev); } static ssize_t lp8788_get_bl_ctl_mode(struct device *dev, -- 2.1.3 From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Mon, 24 Nov 2014 18:05:35 +0000 Subject: [PATCH v2] backlight: lp8788: Deletion of a check before backlight_device_unregister() Message-Id: <5473736F.8070705@users.sourceforge.net> List-Id: References: <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54720DEB.4060109@users.sourceforge.net> <20141124101006.GD4241@x1> In-Reply-To: <20141124101006.GD4241@x1> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Lee Jones Cc: Bryan Wu , Jean-Christophe Plagniol-Villard , Jingoo Han , Tomi Valkeinen , linux-fbdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: Markus Elfring The backlight_device_unregister() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/video/backlight/lp8788_bl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/backlight/lp8788_bl.c b/drivers/video/backlight/lp8788_bl.c index d6c4f6a..24a055c 100644 --- a/drivers/video/backlight/lp8788_bl.c +++ b/drivers/video/backlight/lp8788_bl.c @@ -221,8 +221,7 @@ static void lp8788_backlight_unregister(struct lp8788_bl *bl) { struct backlight_device *bl_dev = bl->bl_dev; - if (bl_dev) - backlight_device_unregister(bl_dev); + backlight_device_unregister(bl_dev); } static ssize_t lp8788_get_bl_ctl_mode(struct device *dev, -- 2.1.3