From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751196AbaKYOQu (ORCPT ); Tue, 25 Nov 2014 09:16:50 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:49111 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751093AbaKYOQs (ORCPT ); Tue, 25 Nov 2014 09:16:48 -0500 X-AuditID: cbfec7f5-b7fc86d0000066b7-06-54748f4eb053 Message-id: <54748F4A.8030003@samsung.com> Date: Tue, 25 Nov 2014 17:16:42 +0300 From: Andrey Ryabinin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-version: 1.0 To: Dmitry Chernenkov Cc: Andrew Morton , Randy Dunlap , Dmitry Vyukov , Konstantin Serebryany , Andrey Konovalov , Yuri Gribov , Konstantin Khlebnikov , Sasha Levin , Christoph Lameter , Joonsoo Kim , Dave Hansen , Andi Kleen , Vegard Nossum , "H. Peter Anvin" , Dave Jones , "x86@kernel.org" , "linux-mm@kvack.org" , LKML , Jonathan Corbet , Michal Marek , Ingo Molnar , Peter Zijlstra Subject: Re: [PATCH v7 01/12] Add kernel address sanitizer infrastructure. References: <1404905415-9046-1-git-send-email-a.ryabinin@samsung.com> <1416852146-9781-1-git-send-email-a.ryabinin@samsung.com> <1416852146-9781-2-git-send-email-a.ryabinin@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPIsWRmVeSWpSXmKPExsVy+t/xK7p+/SUhBj2NzBa/985ktZizfg2b xZFr39ktrn97w2jx5EA7o8Wnlw8YLbZcb2KyeP7wIbvFhIdt7BbTNopbrOxuZrPY/uwtk8XK zgesFpd3zWGzuLfmP6vFpQMLmCxa9l1gsjjee4DJ4u2d6SwWi4/cZrZ492wys8XVVQfZLX5s eMzqIO4xf+dHRo+ds+6yeyzYVOqxeYWWx+I9L5k8Nq3qZPPY9GkSu0fX2ytMHidm/GbxeHJl OpPH4r7JrB4fn95i8Xi/7yqbx5kFR9g9Pm+S8zjR8oU1QCCKyyYlNSezLLVI3y6BK+PzFrWC 26wVd/q3MTUwnmLpYuTkkBAwkXjWeI0RwhaTuHBvPVsXIxeHkMBSRonOZZ+ZQBJCAs1MEpt3 pIPYvAJaEqvO/AdrYBFQldjy+hrYIDYBPYl/s7azgdiiAhESV9bMYYSoF5T4MfkeWI0IUO/5 Dw9YQRYwCxxmk3h+Yip7FyMHh7CAl8TXh6YQi1uYJA4uXAQ2iFMgWOL9ysfMIDXMAuoSU6bk goSZBeQlNq95yzyBUWAWkhWzEKpmIalawMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMk 0r/uYFx6zOoQowAHoxIP7424khAh1sSy4srcQ4wSHMxKIrxBvUAh3pTEyqrUovz4otKc1OJD jEwcnFINjP0hUx+1P0rsqX+6p/9Zd84xhkY5sQvPbrwpqT2VveOrojn3vsuPm9//mz7X6ueO t82bjF44HdoS4iHJN6NvSqx2xqEf3M3pLrsFrLUPJqltjjBQXTd/alXP7tDgBdpnuufxbp7W /+DNDo34iiOGt8r8uI+/SWivkEvj/baO4/3Eru5E/U3mG5VYijMSDbWYi4oTAQZz7gTSAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/25/2014 03:40 PM, Dmitry Chernenkov wrote: > I'm a little concerned with how enabling/disabling works. If an > enable() is forgotten once, it's disabled forever. If disable() is > forgotten once, the toggle is reversed for the forseable future. MB > check for inequality in kasan_enabled()? like current->kasan_depth >= > 0 (will need a signed int for the field). Do you think it's going to > decrease performance? I think that check in kasan_enabled shouldn't hurt much. But it also doesn't look very useful for me. There are only few user of kasan_disable_local/kasan_enable_local, it's easy to review them. And in future we also shouldn't have a lot of new users of those functions. > > LGTM > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f46.google.com (mail-pa0-f46.google.com [209.85.220.46]) by kanga.kvack.org (Postfix) with ESMTP id DA9156B006C for ; Tue, 25 Nov 2014 09:16:51 -0500 (EST) Received: by mail-pa0-f46.google.com with SMTP id lj1so651255pab.33 for ; Tue, 25 Nov 2014 06:16:51 -0800 (PST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com. [210.118.77.12]) by mx.google.com with ESMTPS id re11si1980120pdb.228.2014.11.25.06.16.49 for (version=TLSv1 cipher=RC4-MD5 bits=128/128); Tue, 25 Nov 2014 06:16:50 -0800 (PST) Received: from eucpsbgm2.samsung.com (unknown [203.254.199.245]) by mailout2.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NFL00IJDMGKFC80@mailout2.w1.samsung.com> for linux-mm@kvack.org; Tue, 25 Nov 2014 14:19:32 +0000 (GMT) Message-id: <54748F4A.8030003@samsung.com> Date: Tue, 25 Nov 2014 17:16:42 +0300 From: Andrey Ryabinin MIME-version: 1.0 Subject: Re: [PATCH v7 01/12] Add kernel address sanitizer infrastructure. References: <1404905415-9046-1-git-send-email-a.ryabinin@samsung.com> <1416852146-9781-1-git-send-email-a.ryabinin@samsung.com> <1416852146-9781-2-git-send-email-a.ryabinin@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dmitry Chernenkov Cc: Andrew Morton , Randy Dunlap , Dmitry Vyukov , Konstantin Serebryany , Andrey Konovalov , Yuri Gribov , Konstantin Khlebnikov , Sasha Levin , Christoph Lameter , Joonsoo Kim , Dave Hansen , Andi Kleen , Vegard Nossum , "H. Peter Anvin" , Dave Jones , "x86@kernel.org" , "linux-mm@kvack.org" , LKML , Jonathan Corbet , Michal Marek , Ingo Molnar , Peter Zijlstra On 11/25/2014 03:40 PM, Dmitry Chernenkov wrote: > I'm a little concerned with how enabling/disabling works. If an > enable() is forgotten once, it's disabled forever. If disable() is > forgotten once, the toggle is reversed for the forseable future. MB > check for inequality in kasan_enabled()? like current->kasan_depth >= > 0 (will need a signed int for the field). Do you think it's going to > decrease performance? I think that check in kasan_enabled shouldn't hurt much. But it also doesn't look very useful for me. There are only few user of kasan_disable_local/kasan_enable_local, it's easy to review them. And in future we also shouldn't have a lot of new users of those functions. > > LGTM > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org