From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753403AbaKZWaz (ORCPT ); Wed, 26 Nov 2014 17:30:55 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:38583 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751139AbaKZWay (ORCPT ); Wed, 26 Nov 2014 17:30:54 -0500 Message-ID: <54765499.7080406@ti.com> Date: Wed, 26 Nov 2014 16:30:49 -0600 From: Suman Anna User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Ohad Ben-Cohen CC: Rusty Russell , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , Dave Gerlach Subject: Re: [PATCHv2] rpmsg: compute number of buffers to allocate from vrings References: <1410892387-30596-1-git-send-email-s-anna@ti.com> <5464EE5C.8090904@ti.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ohad, > > On Thu, Nov 13, 2014 at 7:46 PM, Suman Anna wrote: >> Hi Ohad, >> >> On 09/16/2014 01:33 PM, Suman Anna wrote: >>> The buffers to be used for communication are allocated during the >>> rpmsg virtio driver's probe, and the total number of buffers is >>> currently hard-coded to 512. The vring configuration can vary from >>> one platform to another or between different remote processors. The >>> setup of the receive buffers will throw a WARN_ON if the associated >>> vrings are configured with less than 256 buffers (in each direction). >>> So, adjust this hard-coded value to rely on the number of buffers the >>> virtqueue vring is setup with, but also limit to use 256 buffers at >>> most in each direction to avoid wacky resource tables consuming up >>> unreasonable memory. >>> >>> NOTE: The number of buffers is already assumed to be symmetrical >>> in each direction, and that logic is not unchanged. >>> >>> Signed-off-by: Suman Anna >>> --- >>> v2 changes: >>> - add upper limit on buffers and update comments >>> - revise patch description >> >> Any comments on this one, if not can you pick this up for 3.19? > > Did some small changes - untested, not even compiled - can you please > make sure it works for you? Yep, I have reviewed and verified the changes, it is good to go. Thanks, Suman