Re: [PATCH 06/11] ASoC: tlv320aix31xx: Cleanup manual bias level transitions

[Jyri Sarha <jsarha@ti.com>]

On 11/26/2014 09:57 PM, Lars-Peter Clausen wrote:
> Set the CODEC driver's suspend_bias_off flag rather than manually going to
> SND_SOC_BIAS_OFF in suspend and SND_SOC_BIAS_STANDBY in resume. This makes
> the code a bit shorter and cleaner.
>
> Since the ASoC core now takes care of setting the bias level to
> SND_SOC_BIAS_OFF when removing the CODEC there is no need to do it manually
> anymore either.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Acked-by: Jyri Sarha <jsarha@ti.com>

> ---
>   sound/soc/codecs/tlv320aic31xx.c | 18 ++----------------
>   1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/sound/soc/codecs/tlv320aic31xx.c b/sound/soc/codecs/tlv320aic31xx.c
> index 93de5dd..dc3223d 100644
> --- a/sound/soc/codecs/tlv320aic31xx.c
> +++ b/sound/soc/codecs/tlv320aic31xx.c
> @@ -1057,18 +1057,6 @@ static int aic31xx_set_bias_level(struct snd_soc_codec *codec,
>   	return 0;
>   }
>
> -static int aic31xx_suspend(struct snd_soc_codec *codec)
> -{
> -	aic31xx_set_bias_level(codec, SND_SOC_BIAS_OFF);
> -	return 0;
> -}
> -
> -static int aic31xx_resume(struct snd_soc_codec *codec)
> -{
> -	aic31xx_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
> -	return 0;
> -}
> -
>   static int aic31xx_codec_probe(struct snd_soc_codec *codec)
>   {
>   	int ret = 0;
> @@ -1111,8 +1099,6 @@ static int aic31xx_codec_remove(struct snd_soc_codec *codec)
>   {
>   	struct aic31xx_priv *aic31xx = snd_soc_codec_get_drvdata(codec);
>   	int i;
> -	/* power down chip */
> -	aic31xx_set_bias_level(codec, SND_SOC_BIAS_OFF);
>
>   	for (i = 0; i < ARRAY_SIZE(aic31xx->supplies); i++)
>   		regulator_unregister_notifier(aic31xx->supplies[i].consumer,
> @@ -1124,9 +1110,9 @@ static int aic31xx_codec_remove(struct snd_soc_codec *codec)
>   static struct snd_soc_codec_driver soc_codec_driver_aic31xx = {
>   	.probe			= aic31xx_codec_probe,
>   	.remove			= aic31xx_codec_remove,
> -	.suspend		= aic31xx_suspend,
> -	.resume			= aic31xx_resume,
>   	.set_bias_level		= aic31xx_set_bias_level,
> +	.suspend_bias_off	= true,
> +
>   	.controls		= aic31xx_snd_controls,
>   	.num_controls		= ARRAY_SIZE(aic31xx_snd_controls),
>   	.dapm_widgets		= aic31xx_dapm_widgets,
>