Re: [PATCH 12/12] arm64: dts: qcom: msm8998-mtp: correct board compatible

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/12] arm64: dts: qcom: msm8998-mtp: correct board compatible
Date: Sun, 22 May 2022 11:20:15 +0200	[thread overview]
Message-ID: <5476b457-5b1d-8ccb-302c-b24d26136c27@linaro.org> (raw)
In-Reply-To: <20b56d26-6f30-2f78-3e27-771c7e7684ec@somainline.org>

On 22/05/2022 11:11, Konrad Dybcio wrote:
> 
> 
> On 21.05.2022 18:45, Krzysztof Kozlowski wrote:
>> Add qcom,msm8998 SoC fallback to the board compatible.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/msm8998-mtp.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
>> index 66540d2ca13b..db240a3207dc 100644
>> --- a/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/msm8998-mtp.dts
>> @@ -7,7 +7,7 @@
>>  
>>  / {
>>  	model = "Qualcomm Technologies, Inc. MSM8998 v1 MTP";
> A bit off-topic, but should this board still be considered supported? If it really is msm8998v1, it should not work in the current state of mainline, as there are many differences between the pre-production v1 and the final v2.1, even as deep as in the clock tree.

Unless you are sure there are no users or it is not working, there is
not much benefit to remove such board. Specially that it's DTSI is
re-used by one more - fxtec-pro1.

Best regards,
Krzysztof