From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Liu,
Jijiang" <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"Ananyev,
Konstantin"
<konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH 1/3] mbuf:add two TX offload flags and change three fields
Date: Mon, 01 Dec 2014 10:52:03 +0100 [thread overview]
Message-ID: <547C3A43.8020009@6wind.com> (raw)
In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9F58E-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hi Jijiang,
On 12/01/2014 03:30 AM, Liu, Jijiang wrote:
>> After another thought, I think that the way you proposed is a better one.
>> I gives us more flexibility:
>> let's say for now we'll keep both l2_len and outer_l2_len as 7 bit fields, and upper
>> layer would have to:
>> mb->l2_len = eth_hdr_in + vxlan_hdr;
>
> A question, how to fill the mb->l2_len for IP in IP, IP in GRE tunneling packet that is no inner L2 header?
> What is the rule?
> Or you think it should be mb->l2_len = 0 + l4_tun_len; ??
We could have the following rule:
- the l2_len starts after the end of outer_l2_len + outer_l3_len (if
they are not 0)
- l2_len is the length of all headers up to the first ip or ipv6
header
Examples:
Ether/IP/UDP/xxx
m->outer_l2_len = 0
m->outer_l3_len = 0
m->l2_len = sizeof(ether)
m->l3_len = sizeof(ip)
m->l4_len = sizeof(udp)
Ether/IP/IP/UDP/xxx
m->outer_l2_len = sizeof(ether)
m->outer_l3_len = sizeof(ip)
m->l2_len = 0
m->l3_len = sizeof(ip)
m->l4_len = sizeof(udp)
Ether/IP/GRE/IP/UDP/xxx
m->outer_l2_len = sizeof(ether)
m->outer_l3_len = sizeof(ip)
m->l2_len = sizeof(gre)
m->l3_len = sizeof(ip)
m->l4_len = sizeof(udp)
Ether/IP/UDP/vxlan/Ether/IP/UDP/xxx
m->outer_l2_len = sizeof(ether)
m->outer_l3_len = sizeof(ip)
m->l2_len = sizeof(udp) + sizeof(vxlan) + sizeof(ether)
m->l3_len = sizeof(ip)
m->l4_len = sizeof(udp)
Regards,
Olivier
next prev parent reply other threads:[~2014-12-01 9:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 8:18 [PATCH 0/3] i40e VXLAN TX checksum rework Jijiang Liu
[not found] ` <1417076319-629-1-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-27 8:18 ` [PATCH 1/3] mbuf:add two TX offload flags and change three fields Jijiang Liu
[not found] ` <1417076319-629-2-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-27 10:00 ` Olivier MATZ
[not found] ` <5476F626.2020708-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-27 13:14 ` Liu, Jijiang
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EE79-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-28 9:17 ` Olivier MATZ
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EEA0@SHSMSX101.ccr.corp.intel.com>
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EEA0-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-27 14:56 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BADB8-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-27 17:01 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BAE90-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-28 10:45 ` Olivier MATZ
[not found] ` <54785264.1020208-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-28 11:16 ` Ananyev, Konstantin
2014-11-30 14:50 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BB795-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-01 2:30 ` Liu, Jijiang
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9F58E-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-01 9:52 ` Olivier MATZ [this message]
[not found] ` <547C3A43.8020009-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-01 11:58 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BBB21-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-01 12:28 ` Olivier MATZ
[not found] ` <547C5EE7.1060100-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-12-01 13:07 ` Liu, Jijiang
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9F7B3-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-01 14:31 ` Ananyev, Konstantin
2014-11-27 8:18 ` [PATCH 2/3] i40e:PMD change for VXLAN TX checksum Jijiang Liu
2014-11-27 8:18 ` [PATCH 3/3] testpmd:rework csum forward engine Jijiang Liu
[not found] ` <1417076319-629-4-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-11-27 10:23 ` Olivier MATZ
2014-11-27 8:50 ` [PATCH 0/3] i40e VXLAN TX checksum rework Liu, Jijiang
2014-11-27 9:44 ` Olivier MATZ
[not found] ` <5476F28F.7010802-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-27 10:12 ` Olivier MATZ
[not found] ` <5476F919.9030906-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-11-27 12:06 ` Liu, Jijiang
2014-11-27 12:07 ` Liu, Jijiang
2014-11-27 15:29 ` Ananyev, Konstantin
[not found] ` <2601191342CEEE43887BDE71AB977258213BADE4-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-11-27 16:31 ` Liu, Jijiang
[not found] ` <1ED644BD7E0A5F4091CF203DAFB8E4CC01D9EF72-0J0gbvR4kThpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-12-03 8:02 ` Liu, Jijiang
2014-11-28 9:26 ` Olivier MATZ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C3A43.8020009@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.