From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
Wanpeng Li <wanpeng.li@linux.intel.com>
Subject: Re: [PATCH] KVM: cpuid: mask more bits in leaf 0xd and subleaves
Date: Wed, 03 Dec 2014 13:10:28 +0100 [thread overview]
Message-ID: <547EFDB4.5060709@redhat.com> (raw)
In-Reply-To: <20141203120739.GA26617@potion.brq.redhat.com>
On 03/12/2014 13:07, Radim Krčmář wrote:
>> > Well, there is a WARN just above. :) But I can change it to zero instead.
> Yeah, I wasn't sure about the WARN ... I can only see it trigger after
> host xcr0 changes and we are much more screwed in that case anyway :)
> (But it has a chance of catching a bug, so it isn't only bad.)
>
> The guest expects 0 here, so I'd rather have it ...
Ok, I'll have
if (WARN_ON_ONCE(entry[i].ecx & 1))
continue;
}
entry[i].ecx = 0;
entry[i].edx = 0;
...
Thanks for the review!
Paolo
prev parent reply other threads:[~2014-12-03 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 13:09 [PATCH] KVM: cpuid: mask more bits in leaf 0xd and subleaves Paolo Bonzini
2014-12-02 23:05 ` Radim Krčmář
2014-12-03 8:04 ` Paolo Bonzini
2014-12-03 12:07 ` Radim Krčmář
2014-12-03 12:10 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547EFDB4.5060709@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkrcmar@redhat.com \
--cc=wanpeng.li@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.