From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752300AbaLCNUf (ORCPT ); Wed, 3 Dec 2014 08:20:35 -0500 Received: from va-smtp01.263.net ([54.88.144.211]:44647 "EHLO va-smtp01.263.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751149AbaLCNUd (ORCPT ); Wed, 3 Dec 2014 08:20:33 -0500 X-RL-SENDER: andy.yan@rock-chips.com X-FST-TO: galak@codeaurora.org X-SENDER-IP: 121.15.173.1 X-LOGIN-NAME: andy.yan@rock-chips.com X-UNIQUE-TAG: <6ad9ab66f42dc741646a4fc1dcdf0c87> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <547F0E06.5040106@rock-chips.com> Date: Wed, 03 Dec 2014 21:20:06 +0800 From: Andy Yan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Philipp Zabel CC: airlied@linux.ie, heiko@sntech.de, fabio.estevam@freescale.com, rmk+kernel@arm.linux.org.uk, Greg Kroah-Hartman , Grant Likely , Rob Herring , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , Zubair.Kakakhel@imgtec.com, djkurtz@google.com, ykk@rock-chips.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, jay.xu@rock-chips.com, Pawel Moll , mark.yao@rock-chips.com, Mark Rutland , vladimir_zapolskiy@mentor.com, Ian Campbell , Kumar Gala Subject: Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506327-18908-1-git-send-email-andy.yan@rock-chips.com> <1417515882.3411.8.camel@pengutronix.de> <547DB1ED.7000409@rock-chips.com> <1417525257.3411.12.camel@pengutronix.de> <547F02CF.9010804@rock-chips.com> <1417612197.5124.12.camel@pengutronix.de> In-Reply-To: <1417612197.5124.12.camel@pengutronix.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philipp: On 2014年12月03日 21:09, Philipp Zabel wrote: > Hi Andy, > > Am Mittwoch, den 03.12.2014, 20:32 +0800 schrieb Andy Yan: >>> My question is not about the available gates at the SoC level, but about >>> the actual clock inputs from point of view of the HDMI TX IP. >>> >>> It could be that the hdmi_ctrl_clk gates all inputs to the module and >>> bus clocks together. If so, you could just reuse "isfr" and "iahb" and >>> set it to the same clock. If not, we'd need to think of something else. >>> Unfortunately I don't have any Synopsys documentation of the HDMI TX at >>> that level. >> After confirming with the IC designer, we finally make clear that >> Rockchip RK3288 almost use the same clock design with imx: >> clk-----iahbclk, used for hdmi module and bus >> hdcp_clk-----isfrclk, used for hdcp and i2cm >> cecclk -----cecclk, but this clk can be gated on rockchip, this is >> different with imx, >> but we don't handle the cec stuff now. So i will try to reuse the >> imx clk binds. do you >> think that is ok? > Thank you for taking the time to verify this. So we should move the > clock handling out of the soc specific parts into the common driver and > reuse the existing clock bindings ("iahb", "isfr"). > I'd suggest to add the "cec" clock now to the binding document as an > optional clock, then you can already specify it in the rockchip dtsi. ok > > regards > Philipp > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Yan Subject: Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support Date: Wed, 03 Dec 2014 21:20:06 +0800 Message-ID: <547F0E06.5040106@rock-chips.com> References: <1417505778-18341-1-git-send-email-andy.yan@rock-chips.com> <1417506327-18908-1-git-send-email-andy.yan@rock-chips.com> <1417515882.3411.8.camel@pengutronix.de> <547DB1ED.7000409@rock-chips.com> <1417525257.3411.12.camel@pengutronix.de> <547F02CF.9010804@rock-chips.com> <1417612197.5124.12.camel@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1417612197.5124.12.camel@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Philipp Zabel Cc: Mark Rutland , heiko@sntech.de, airlied@linux.ie, dri-devel@lists.freedesktop.org, ykk@rock-chips.com, devel@driverdev.osuosl.org, Pawel Moll , linux-rockchip@lists.infradead.org, Grant Likely , Dave Airlie , jay.xu@rock-chips.com, devicetree@vger.kernel.org, Zubair.Kakakhel@imgtec.com, Arnd Bergmann , Ian Campbell , Inki Dae , Rob Herring , Sean Paul , rmk+kernel@arm.linux.org.uk, mark.yao@rock-chips.com, fabio.estevam@freescale.com, Josh Boyer , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, djkurtz@google.com, Kumar Gala , Shawn Guo , vladimir_zapolskiy@mentor.com List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcDoKT24gMjAxNOW5tDEy5pyIMDPml6UgMjE6MDksIFBoaWxpcHAgWmFiZWwgd3Jv dGU6Cj4gSGkgQW5keSwKPgo+IEFtIE1pdHR3b2NoLCBkZW4gMDMuMTIuMjAxNCwgMjA6MzIgKzA4 MDAgc2NocmllYiBBbmR5IFlhbjoKPj4+IE15IHF1ZXN0aW9uIGlzIG5vdCBhYm91dCB0aGUgYXZh aWxhYmxlIGdhdGVzIGF0IHRoZSBTb0MgbGV2ZWwsIGJ1dCBhYm91dAo+Pj4gdGhlIGFjdHVhbCBj bG9jayBpbnB1dHMgZnJvbSBwb2ludCBvZiB2aWV3IG9mIHRoZSBIRE1JIFRYIElQLgo+Pj4KPj4+ IEl0IGNvdWxkIGJlIHRoYXQgdGhlIGhkbWlfY3RybF9jbGsgZ2F0ZXMgYWxsIGlucHV0cyB0byB0 aGUgbW9kdWxlIGFuZAo+Pj4gYnVzIGNsb2NrcyB0b2dldGhlci4gSWYgc28sIHlvdSBjb3VsZCBq dXN0IHJldXNlICJpc2ZyIiBhbmQgImlhaGIiIGFuZAo+Pj4gc2V0IGl0IHRvIHRoZSBzYW1lIGNs b2NrLiBJZiBub3QsIHdlJ2QgbmVlZCB0byB0aGluayBvZiBzb21ldGhpbmcgZWxzZS4KPj4+IFVu Zm9ydHVuYXRlbHkgSSBkb24ndCBoYXZlIGFueSBTeW5vcHN5cyBkb2N1bWVudGF0aW9uIG9mIHRo ZSBIRE1JIFRYIGF0Cj4+PiB0aGF0IGxldmVsLgo+PiAgICAgIEFmdGVyIGNvbmZpcm1pbmcgd2l0 aCB0aGUgSUMgZGVzaWduZXIsIHdlIGZpbmFsbHkgbWFrZSBjbGVhciB0aGF0Cj4+ICAgICAgUm9j a2NoaXAgUkszMjg4IGFsbW9zdCB1c2UgdGhlIHNhbWUgY2xvY2sgZGVzaWduIHdpdGggaW14Ogo+ PiAgICAgIGNsay0tLS0taWFoYmNsaywgdXNlZCBmb3IgaGRtaSBtb2R1bGUgYW5kIGJ1cwo+PiAg ICAgIGhkY3BfY2xrLS0tLS1pc2ZyY2xrLCB1c2VkIGZvciBoZGNwIGFuZCBpMmNtCj4+ICAgICAg Y2VjY2xrIC0tLS0tY2VjY2xrLCBidXQgdGhpcyBjbGsgY2FuIGJlIGdhdGVkIG9uIHJvY2tjaGlw LCB0aGlzIGlzCj4+IGRpZmZlcmVudCB3aXRoIGlteCwKPj4gICAgICBidXQgd2UgZG9uJ3QgaGFu ZGxlIHRoZSBjZWMgc3R1ZmYgbm93LiBTbyBpIHdpbGwgdHJ5IHRvIHJldXNlIHRoZQo+PiBpbXgg Y2xrIGJpbmRzLiBkbyB5b3UKPj4gICAgIHRoaW5rIHRoYXQgaXMgb2s/Cj4gVGhhbmsgeW91IGZv ciB0YWtpbmcgdGhlIHRpbWUgdG8gdmVyaWZ5IHRoaXMuIFNvIHdlIHNob3VsZCBtb3ZlIHRoZQo+ IGNsb2NrIGhhbmRsaW5nIG91dCBvZiB0aGUgc29jIHNwZWNpZmljIHBhcnRzIGludG8gdGhlIGNv bW1vbiBkcml2ZXIgYW5kCj4gcmV1c2UgdGhlIGV4aXN0aW5nIGNsb2NrIGJpbmRpbmdzICgiaWFo YiIsICJpc2ZyIikuCj4gSSdkIHN1Z2dlc3QgdG8gYWRkIHRoZSAiY2VjIiBjbG9jayBub3cgdG8g dGhlIGJpbmRpbmcgZG9jdW1lbnQgYXMgYW4KPiBvcHRpb25hbCBjbG9jaywgdGhlbiB5b3UgY2Fu IGFscmVhZHkgc3BlY2lmeSBpdCBpbiB0aGUgcm9ja2NoaXAgZHRzaS4KICAgb2sKPgo+IHJlZ2Fy ZHMKPiBQaGlsaXBwCj4KPgo+CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkZXZlbCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9y ZwpodHRwOi8vZHJpdmVyZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcml2ZXJkZXYtZGV2ZWwK